debug missing identities

Author: nojnhuh

azure/services/virtualmachines/virtualmachines.go

@@ -39,7 +39,14 @@ import (
 )
 
 const serviceName = "virtualmachine"
-const vmMissingUAI = "VM is missing expected user assigned identity with client ID: "
+
+func vmMissingUAI(expectedKey string, actualIdentities []infrav1.UserAssignedIdentity) string {
+	var actual []string
+	for _, a := range actualIdentities {
+		actual = append(actual, a.ProviderID)
+	}
+	return "VM is missing expected user assigned identity with ID " + expectedKey + ", VM has identities " + strings.Join(actual, ", ")
+}
 
 // VMScope defines the scope interface for a virtual machines service.
 type VMScope interface {
@@ -173,7 +180,7 @@ func (s *Service) checkUserAssignedIdentities(specIdentities []infrav1.UserAssig
 	for _, expectedIdentity := range specIdentities {
 		_, exists := actualMap[expectedIdentity.ProviderID]
 		if !exists {
-			s.Scope.SetConditionFalse(infrav1.VMIdentitiesReadyCondition, infrav1.UserAssignedIdentityMissingReason, clusterv1.ConditionSeverityWarning, vmMissingUAI+expectedIdentity.ProviderID)
+			s.Scope.SetConditionFalse(infrav1.VMIdentitiesReadyCondition, infrav1.UserAssignedIdentityMissingReason, clusterv1.ConditionSeverityWarning, vmMissingUAI(expectedIdentity.ProviderID, vmIdentities))
 			return
 		}
 	}

azure/services/virtualmachines/virtualmachines_test.go

@@ -358,7 +358,7 @@ func TestCheckUserAssignedIdentities(t *testing.T) {
 			scopeMock := mock_virtualmachines.NewMockVMScope(mockCtrl)
 
 			if tc.expectedKey != "" {
-				scopeMock.EXPECT().SetConditionFalse(infrav1.VMIdentitiesReadyCondition, infrav1.UserAssignedIdentityMissingReason, clusterv1.ConditionSeverityWarning, vmMissingUAI+tc.expectedKey).Times(1)
+				scopeMock.EXPECT().SetConditionFalse(infrav1.VMIdentitiesReadyCondition, infrav1.UserAssignedIdentityMissingReason, clusterv1.ConditionSeverityWarning, vmMissingUAI(tc.expectedKey, tc.actualIdentities)).Times(1)
 			}
 			s := &Service{
 				Scope: scopeMock,

controllers/azuremachine_controller.go

@@ -289,8 +289,8 @@ func (amr *AzureMachineReconciler) reconcileNormal(ctx context.Context, machineS
 	if cond != nil && cond.Status == corev1.ConditionFalse && cond.Reason == infrav1.UserAssignedIdentityMissingReason {
 		amr.Recorder.Eventf(machineScope.AzureMachine, corev1.EventTypeWarning, infrav1.UserAssignedIdentityMissingReason, "VM is unhealthy")
 		machineScope.SetFailureReason(azure.UnsupportedChange)
-		machineScope.SetFailureMessage(errors.New("VM identities are not ready"))
-		return reconcile.Result{}, errors.New("VM identities are not ready")
+		machineScope.SetFailureMessage(errors.New(cond.Message))
+		return reconcile.Result{}, errors.New(cond.Message)
 	}
 
 	ams, err := amr.createAzureMachineService(machineScope)