-
Notifications
You must be signed in to change notification settings - Fork 637
✨ Add AWSManagedPoolTemplate #5725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @k0da! |
|
Hi @k0da. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
af292a3 to
d790693
Compare
|
/ok-to-test |
| @@ -0,0 +1,55 @@ | |||
| /* | |||
| Copyright 2021 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Copyright 2021 The Kubernetes Authors. | |
| Copyright 2025 The Kubernetes Authors. |
|
|
||
| // AWSManagedMachinePoolTemplateSpec defines the desired state of AWSManagedMachinePoolTemplate. | ||
| type AWSManagedMachinePoolTemplateSpec struct { | ||
| Template *AWSManagedMachinePool `json:"template"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Template *AWSManagedMachinePool `json:"template"` | |
| Template AWSManagedMachinePoolTemplateResource `json:"template"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to add AWSManagedMachinePoolTemplateResource which will be something like:
type AWSManagedMachinePoolTemplateResource struct {
// Standard object's metadata.
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
ObjectMeta clusterv1.ObjectMeta `json:"metadata,omitempty,omitzero"`
Spec AWSManagedMachinePoolSpec `json:"spec"`
}| var _ webhook.CustomValidator = &awsManagedMachinePoolWebhook{} | ||
|
|
||
| func (r *AWSManagedMachinePool) validateScaling() field.ErrorList { | ||
| func validateScaling(r *AWSManagedMachinePool) field.ErrorList { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will need to be changed to validate against AWSManagedMachinePoolSpec. See later comment for the context.
2b31714 to
d60de14
Compare
Signed-off-by: Dinar Valeev <k0da@opensuse.org>
d60de14 to
51f3f07
Compare
|
@richardcase thanks for review. Addresses all you review points, could you please recheck? Thank you |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds AWSManagedMachinePoolTemplate support useful to be used in combination with cluster classes.
Special notes for your reviewer:
Checklist:
Release note: