Skip to content

Conversation

@k0da
Copy link

@k0da k0da commented Oct 28, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds AWSManagedMachinePoolTemplate support useful to be used in combination with cluster classes.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add AWSManagedMachinePoolTemplate support, to be usable with ClusterClasses

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @k0da!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @k0da. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k0da k0da changed the title xsAdd AWSManagedPoolTemplate (:sparkles:) Add AWSManagedPoolTemplate Oct 28, 2025
@k0da k0da changed the title (:sparkles:) Add AWSManagedPoolTemplate ✨ Add AWSManagedPoolTemplate Oct 28, 2025
@k0da k0da force-pushed the awsmanagedpooltemplate branch from af292a3 to d790693 Compare October 28, 2025 13:00
@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2025
@@ -0,0 +1,55 @@
/*
Copyright 2021 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2021 The Kubernetes Authors.
Copyright 2025 The Kubernetes Authors.


// AWSManagedMachinePoolTemplateSpec defines the desired state of AWSManagedMachinePoolTemplate.
type AWSManagedMachinePoolTemplateSpec struct {
Template *AWSManagedMachinePool `json:"template"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Template *AWSManagedMachinePool `json:"template"`
Template AWSManagedMachinePoolTemplateResource `json:"template"`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to add AWSManagedMachinePoolTemplateResource which will be something like:

type AWSManagedMachinePoolTemplateResource struct {
	// Standard object's metadata.
	// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
	// +optional
	ObjectMeta clusterv1.ObjectMeta `json:"metadata,omitempty,omitzero"`

	Spec AWSManagedMachinePoolSpec `json:"spec"`
}

var _ webhook.CustomValidator = &awsManagedMachinePoolWebhook{}

func (r *AWSManagedMachinePool) validateScaling() field.ErrorList {
func validateScaling(r *AWSManagedMachinePool) field.ErrorList {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need to be changed to validate against AWSManagedMachinePoolSpec. See later comment for the context.

@k0da k0da force-pushed the awsmanagedpooltemplate branch 2 times, most recently from 2b31714 to d60de14 Compare November 10, 2025 22:13
Signed-off-by: Dinar Valeev <k0da@opensuse.org>
@k0da k0da force-pushed the awsmanagedpooltemplate branch from d60de14 to 51f3f07 Compare November 10, 2025 22:26
@k0da k0da requested a review from richardcase November 11, 2025 11:19
@k0da
Copy link
Author

k0da commented Nov 11, 2025

@richardcase thanks for review. Addresses all you review points, could you please recheck? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants