fix: ensure correct APIVersion in AWSClusterControllerIdentity conversion

The conversion webhook for AWSClusterControllerIdentity was failing with:
- expected infrastructure.cluster.x-k8s.io/v1beta2, received infrastructure.cluster.x-k8s.io/v1beta1
- Error from server: conversion webhook returned invalid object: invalid groupVersion

Root cause:
The auto-generated conversion function (Convert_v1beta1_AWSClusterControllerIdentity_To_v1beta2_AWSClusterControllerIdentity)
copies TypeMeta directly from the source object, which includes the APIVersion field. This results in
the converted v1beta2 object retaining the v1beta1 APIVersion, causing the conversion webhook to reject
it as invalid.

Fix:
Explicitly set the APIVersion to the target version (v1beta2) after calling the auto-generated
conversion function in both ConvertTo methods for AWSClusterControllerIdentity and
AWSClusterControllerIdentityList. This ensures the converted object has the correct APIVersion
that matches the target API version expected by Kubernetes.

This fix ensures that when Kubernetes requests conversion from v1beta1 to v1beta2, the webhook
returns objects with the correct APIVersion, allowing the conversion to succeed.

Author: dntosas

api/v1beta1/awsidentity_conversion.go

@@ -25,7 +25,12 @@ import (
 // ConvertTo converts the v1beta1 AWSClusterControllerIdentity receiver to a v1beta2 AWSClusterControllerIdentity.
 func (src *AWSClusterControllerIdentity) ConvertTo(dstRaw conversion.Hub) error {
 	dst := dstRaw.(*infrav1.AWSClusterControllerIdentity)
-	return Convert_v1beta1_AWSClusterControllerIdentity_To_v1beta2_AWSClusterControllerIdentity(src, dst, nil)
+	if err := Convert_v1beta1_AWSClusterControllerIdentity_To_v1beta2_AWSClusterControllerIdentity(src, dst, nil); err != nil {
+		return err
+	}
+	// Ensure the APIVersion is set correctly after conversion
+	dst.APIVersion = infrav1.GroupVersion.String()
+	return nil
 }
 
 // ConvertFrom converts the v1beta2 AWSClusterControllerIdentity to a v1beta1 AWSClusterControllerIdentity.
@@ -38,7 +43,12 @@ func (dst *AWSClusterControllerIdentity) ConvertFrom(srcRaw conversion.Hub) erro
 // ConvertTo converts the v1beta1 AWSClusterControllerIdentityList receiver to a v1beta2 AWSClusterControllerIdentityList.
 func (src *AWSClusterControllerIdentityList) ConvertTo(dstRaw conversion.Hub) error {
 	dst := dstRaw.(*infrav1.AWSClusterControllerIdentityList)
-	return Convert_v1beta1_AWSClusterControllerIdentityList_To_v1beta2_AWSClusterControllerIdentityList(src, dst, nil)
+	if err := Convert_v1beta1_AWSClusterControllerIdentityList_To_v1beta2_AWSClusterControllerIdentityList(src, dst, nil); err != nil {
+		return err
+	}
+	// Ensure the APIVersion is set correctly after conversion
+	dst.APIVersion = infrav1.GroupVersion.String()
+	return nil
 }
 
 // ConvertFrom converts the v1beta2 AWSClusterControllerIdentityList to a v1beta1 AWSClusterControllerIdentityList.