Skip to content

Commit 3cb4cdd

Browse files
committed
docs: fixes minor issues in nodeadm kep
1 parent dbfb484 commit 3cb4cdd

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

docs/proposal/20250922-nodeadm-bootstrap.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ This KEP proposes a new type that handles bootstrapping with `nodeadm` alone. Th
8888
The **cons** are:
8989

9090
* The scope of work to support EKS nodes grows significantly and is pushed out.
91-
* Users need to know that setting `AWSMachine.Spec.Ami.EKSLookupType` to `AmazonLinux` won’t work with the new `nodeadm` bootstrap method.
9291

9392
### User Stories
9493

@@ -111,10 +110,6 @@ This KEP proposes a new type that handles bootstrapping with `nodeadm` alone. Th
111110
// +optional
112111
Containerd *ContainerdOptions `json:"containerd,omitempty"`
113112
114-
// Instance contains options for the node's operating system and devices.
115-
// +optional
116-
Instance *InstanceOptions `json:"instance,omitempty"`
117-
118113
// FeatureGates holds key-value pairs to enable or disable application features.
119114
// +optional
120115
FeatureGates map[Feature]bool `json:"featureGates,omitempty"`
@@ -282,6 +277,7 @@ A valid concern that CAPA users will have is upgrading existing clusters to mach
282277
kind: NodeadmConfigTemplate
283278
name: default-133
284279
infrastructureRef:
280+
apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
285281
kind: AWSMachinePool
286282
name: default
287283
version: v1.33.0
@@ -294,11 +290,6 @@ A valid concern that CAPA users will have is upgrading existing clusters to mach
294290
* E2e tests exercising the migration from EKSConfig to NodeadmConfig,
295291

296292

297-
## Drawbacks
298-
299-
* The scope of work to support EKS nodes grows significantly and is pushed out.
300-
* Users need to know that setting `AWSMachine.Spec.Ami.EKSLookupType` to `AmazonLinux` won’t work with the new `nodeadm` bootstrap method.
301-
302293
-----
303294

304295
## Alternatives

0 commit comments

Comments
 (0)