Skip to content

Commit fd7a3d8

Browse files
authored
fix: controller make deploy set image (#643)
related: #596 When refactoring the controller manifests - a change was missed to ensure the `make deploy` command - which calls `kustomize edit set image ...` properly replaces the `controller` `image` reference. In line with `backend` and `frontend` - the manifest should initially just specify `workspaces-controller` as the image name - and that _exact value_ should then be used in `kustomize edit set image`. This commit brings that alignment into place. Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
1 parent 076d496 commit fd7a3d8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

workspaces/controller/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified
138138

139139
.PHONY: deploy
140140
deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config.
141-
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
141+
cd config/manager && $(KUSTOMIZE) edit set image workspaces-controller=${IMG}
142142
$(KUSTOMIZE) build config/default | $(KUBECTL) apply -f -
143143

144144
.PHONY: undeploy

workspaces/controller/config/manager/manager.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
- --leader-elect
5454
- --health-probe-bind-address=:8081
5555
- --metrics-bind-address=0
56-
image: workspaces-controller:latest
56+
image: workspaces-controller
5757
imagePullPolicy: IfNotPresent
5858
name: manager
5959
securityContext:

0 commit comments

Comments
 (0)