Skip to content

Commit a9a367a

Browse files
author
Hen Schwartz
committed
Upgrade Go to 1.24 for pvcviewer-controller
- Update CI workflow pvcviewer_controller_unit_test.yaml to use go-version 1.24 - Update go.mod to go 1.24 - Update Dockerfile GOLANG_VERSION to 1.24 Signed-off-by: Hen Schwartz <hschwart@hschwart-thinkpadp1gen7.raanaii.csb>
1 parent 7c20437 commit a9a367a

File tree

3 files changed

+30
-2
lines changed

3 files changed

+30
-2
lines changed
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
name: Run PVCViewer Controller unit tests
2+
on:
3+
pull_request:
4+
paths:
5+
- components/pvcviewer-controller/**
6+
- releasing/version/VERSION
7+
branches:
8+
- main
9+
- notebooks-v1
10+
- 'v*-branch'
11+
12+
jobs:
13+
build:
14+
runs-on: ubuntu-22.04
15+
steps:
16+
- name: Checkout
17+
uses: actions/checkout@v4
18+
19+
- name: Install Go
20+
uses: actions/setup-go@v5
21+
with:
22+
go-version: "1.24"
23+
check-latest: true
24+
25+
- name: Run unit tests
26+
run: |
27+
cd components/pvcviewer-controller
28+
make test

components/pvcviewer-controller/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
ARG GOLANG_VERSION=1.22.2
2+
ARG GOLANG_VERSION=1.24
33
FROM golang:${GOLANG_VERSION} as builder
44

55
WORKDIR /workspace

components/pvcviewer-controller/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/kubeflow/kubeflow/components/pvc-viewer
22

3-
go 1.22.2
3+
go 1.24
44

55
require (
66
github.com/go-logr/logr v1.4.1

0 commit comments

Comments
 (0)