Skip to content

Commit 0552f2e

Browse files
authored
feat: add status back-reporting support (1/, work applier side) (#327)
1 parent 3d594cc commit 0552f2e

File tree

6 files changed

+664
-42
lines changed

6 files changed

+664
-42
lines changed

pkg/controllers/workapplier/backoff_integration_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ var _ = Describe("exponential backoff", func() {
178178
applyStrategy := &fleetv1beta1.ApplyStrategy{
179179
WhenToTakeOver: fleetv1beta1.WhenToTakeOverTypeIfNoDiff,
180180
}
181-
createWorkObject(workName, memberReservedNSName2, applyStrategy, regularNSJSON)
181+
createWorkObject(workName, memberReservedNSName2, applyStrategy, nil, regularNSJSON)
182182
})
183183

184184
// For simplicity reasons, this test case will skip some of the regular apply op result verification
@@ -395,7 +395,7 @@ var _ = Describe("exponential backoff", func() {
395395
WhenToTakeOver: fleetv1beta1.WhenToTakeOverTypeAlways,
396396
WhenToApply: fleetv1beta1.WhenToApplyTypeAlways,
397397
}
398-
createWorkObject(workName, memberReservedNSName2, applyStrategy, regularNSJSON)
398+
createWorkObject(workName, memberReservedNSName2, applyStrategy, nil, regularNSJSON)
399399
})
400400

401401
// For simplicity reasons, this test case will skip some of the regular apply op result verification

pkg/controllers/workapplier/controller.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,9 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
505505
trackWorkAndManifestProcessingRequestMetrics(work)
506506

507507
// Requeue the Work object with a delay based on the requeue rate limiter.
508+
//
509+
// Note (chenyu1): at this moment the work applier does not register changes on back-reported
510+
// status as a trigger for resetting the rate limiter.
508511
requeueDelay := r.requeueRateLimiter.When(work, bundles)
509512
klog.V(2).InfoS("Requeue the Work object for re-processing", "work", workRef, "delaySeconds", requeueDelay.Seconds())
510513
return ctrl.Result{RequeueAfter: requeueDelay}, nil

0 commit comments

Comments
 (0)