Rust 2024 let-chains to simplify wait Conditions #1792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps MSRV to 1.88.0 and converts existing let-chainable code to use let-chains. Rust 2024 support was added in separately in #1856, and we can use it properly now since 1.88 is like 3 versions behind.
Was originally playing around with it, but actually found that it solves most of the the ergonomic problem with the wait API that I tried to solve earlier in #1498 - it's not quite as elegant but it also doesn't come with any of the problems and is non-breaking.
But if the general setup (outlined in the first commit) is acceptable, I'll rebase at 1.90.Waiting for #1856 to merge.Now ready.