chore: use consts for frequently used id's

Signed-off-by: Bence Csati <bence.csati@axoflow.com>

Author: csatib02

pkg/resources/otel_conf_gen/pipeline/components/exporter/debug_exporter.go

@@ -14,9 +14,11 @@
 
 package exporter
 
+const DebugExporterID = "debug"
+
 func GenerateDebugExporters() map[string]any {
 	result := make(map[string]any)
-	result["debug"] = map[string]any{
+	result[DebugExporterID] = map[string]any{
 		"verbosity": "detailed",
 	}
 

pkg/resources/otel_conf_gen/pipeline/components/exporter/prometheus_exporter.go

@@ -24,6 +24,10 @@ import (
 	"github.com/kube-logging/telemetry-controller/api/telemetry/v1alpha1"
 )
 
+const (
+	DefaultPrometheusExporterID = "prometheus/message_metrics_exporter"
+)
+
 type TLSServerConfig struct {
 	// squash ensures fields are correctly decoded in embedded struct.
 	v1alpha1.TLSSetting `json:",inline"`
@@ -125,7 +129,7 @@ func GenerateMetricsExporters() map[string]any {
 	}
 
 	metricsExporters := make(map[string]any)
-	metricsExporters["prometheus/message_metrics_exporter"] = defaultPrometheusExporterConfig
+	metricsExporters[DefaultPrometheusExporterID] = defaultPrometheusExporterConfig
 
 	return metricsExporters
 }

pkg/resources/otel_conf_gen/pipeline/components/processor/attributes_processor.go

@@ -74,7 +74,7 @@ func GenerateOutputExporterNameProcessor(outputName string) AttributesProcessor
 
 func GenerateMetricsProcessors() map[string]any {
 	metricsProcessors := make(map[string]any)
-	metricsProcessors["deltatocumulative"] = DeltaToCumulativeConfig{}
+	metricsProcessors[DefaultDeltaToCumulativeProcessorID] = DeltaToCumulativeConfig{}
 	metricsProcessors["attributes/metricattributes"] = AttributesProcessor{
 		Actions: []AttributesProcessorAction{
 			{

pkg/resources/otel_conf_gen/pipeline/components/processor/delta_to_cumulative_processor.go

@@ -16,6 +16,8 @@ package processor
 
 import "time"
 
+const DefaultDeltaToCumulativeProcessorID = "deltatocumulative"
+
 type DeltaToCumulativeConfig struct {
 	MaxStale   time.Duration `json:"max_stale,omitempty"`
 	MaxStreams int           `json:"max_streams,omitempty"`

pkg/resources/otel_conf_gen/pipeline/pipeline.go

@@ -20,6 +20,8 @@ import (
 	otelv1beta1 "github.com/open-telemetry/opentelemetry-operator/apis/v1beta1"
 
 	"github.com/kube-logging/telemetry-controller/api/telemetry/v1alpha1"
+	"github.com/kube-logging/telemetry-controller/pkg/resources/otel_conf_gen/pipeline/components/exporter"
+	"github.com/kube-logging/telemetry-controller/pkg/resources/otel_conf_gen/pipeline/components/processor"
 )
 
 func GeneratePipeline(receivers, processors, exporters []string) *otelv1beta1.Pipeline {
@@ -55,19 +57,19 @@ func GenerateMetricsPipelines() map[string]*otelv1beta1.Pipeline {
 	metricsPipelines := make(map[string]*otelv1beta1.Pipeline)
 	metricsPipelines["metrics/tenant"] = &otelv1beta1.Pipeline{
 		Receivers:  []string{"count/tenant_metrics"},
-		Processors: []string{"deltatocumulative", "attributes/metricattributes"},
-		Exporters:  []string{"prometheus/message_metrics_exporter"},
+		Processors: []string{processor.DefaultDeltaToCumulativeProcessorID, "attributes/metricattributes"},
+		Exporters:  []string{exporter.DefaultPrometheusExporterID},
 	}
 	metricsPipelines["metrics/output"] = &otelv1beta1.Pipeline{
 		Receivers:  []string{"count/output_metrics"},
-		Processors: []string{"deltatocumulative", "attributes/metricattributes"},
-		Exporters:  []string{"prometheus/message_metrics_exporter"},
+		Processors: []string{processor.DefaultDeltaToCumulativeProcessorID, "attributes/metricattributes"},
+		Exporters:  []string{exporter.DefaultPrometheusExporterID},
 	}
 
 	metricsPipelines["metrics/output_bytes"] = &otelv1beta1.Pipeline{
 		Receivers:  []string{"bytes/exporter"},
-		Processors: []string{"deltatocumulative", "attributes/metricattributes"},
-		Exporters:  []string{"prometheus/message_metrics_exporter"},
+		Processors: []string{processor.DefaultDeltaToCumulativeProcessorID, "attributes/metricattributes"},
+		Exporters:  []string{exporter.DefaultPrometheusExporterID},
 	}
 
 	return metricsPipelines