Skip to content

Conversation

@fekete-robert
Copy link
Collaborator

No description provided.

@fekete-robert fekete-robert marked this pull request as ready for review December 9, 2024 12:07
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is named 4.10 but this docs update is for 4.11?

Comment on lines +100 to +119
### Chart verification
You can verify our charts by running the following command.
```shell
cosign verify "ghcr.io/kube-logging/logging-operator@{sha256-CHART-DIGEST}" \
--certificate-identity "https://github.com/ghcr.io/kube-logging/logging-operator/.github/workflows/artifacts.yaml@{refs/heads/main || refs/tags/<tag_name>}" \
--certificate-oidc-issuer "https://token.actions.githubusercontent.com"
```
- Replace `{sha256-CHART-DIGEST}` with the digest of the image you want to verify. You can find the digests at [ghcr.io/kube-logging/helm-charts/logging-operator](https://ghcr.io/kube-logging/helm-charts/logging-operator). For example, for the 4.11.0 release it's `sha256:233407195e1c97382e7fc0dfb00f9c6cadbba2928a64bfce6be072fc37df20eb`.
- Replace `{refs/heads/main || refs/tags/<tag_name>}` with the reference to the image you want to verify. For example, for the 4.11.0 release, use `refs/tags/4.11.0`.

For example:

```shell
cosign verify "ghcr.io/kube-logging/helm-charts/logging-operator@sha256:233407195e1c97382e7fc0dfb00f9c6cadbba2928a64bfce6be072fc37df20eb" \
--certificate-identity "https://github.com/kube-logging/logging-operator/.github/workflows/artifacts.yaml@refs/tags/4.11.0" \
--certificate-oidc-issuer "https://token.actions.githubusercontent.com"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the beginning of this section it is mentioned that the digest is signed in both cases, so I think we should not explain it twice, since it works the same.

@fekete-robert fekete-robert merged commit 0f1c9fa into master Dec 11, 2024
2 checks passed
@fekete-robert fekete-robert deleted the 4.11-preparations branch December 11, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants