Skip to content

Commit 242a46d

Browse files
committed
current changes
1 parent a8a03f5 commit 242a46d

File tree

4 files changed

+2
-15
lines changed

4 files changed

+2
-15
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
- Changed TABLE_MAP_EVENT will no longer appear after adding events to only/ignore configuration
2323
- Fixed events with dropped columns will return a proper columns amount
2424
- Changed configuration to static calls
25+
- Removed absolute method getConnection from repository
2526

2627
## v2.2.0 (2017-03-10)
2728
- Removed foreign keys from events

src/MySQLReplication/Repository/MySQLRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function getFields($database, $table)
5858
/**
5959
* @return Connection
6060
*/
61-
public function getConnection()
61+
private function getConnection()
6262
{
6363
if (false === $this->connection->ping()) {
6464
$this->connection->close();

src/MySQLReplication/Repository/RepositoryInterface.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ interface RepositoryInterface
1515
*/
1616
public function getFields($database, $table);
1717

18-
/**
19-
* @return mixed
20-
*/
21-
public function getConnection();
22-
2318
/**
2419
* @return bool
2520
*/

tests/Unit/Repository/MySQLRepositoryTest.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,6 @@ public function shouldGetMasterStatus()
9191
self::assertEquals($expected,$this->mySQLRepositoryTest->getMasterStatus());
9292
}
9393

94-
/**
95-
* @test
96-
*/
97-
public function shouldGetConnection()
98-
{
99-
$this->connection->method('ping')->willReturn(false);
100-
self::assertInstanceOf(Connection::class, $this->mySQLRepositoryTest->getConnection());
101-
}
102-
10394
/**
10495
* @test
10596
*/

0 commit comments

Comments
 (0)