Skip to content

Commit 6793ab5

Browse files
committed
sqlite: Update usage update stmt
Need to include NetworkAddressFamily, otherwise update will always match and we will never get two usage rows.
1 parent 8f51473 commit 6793ab5

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

metadata_writer_inventory_conn.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ static int32_t md_inventory_execute_update_usage(struct md_writer_sqlite *mws,
291291

292292
if (sqlite3_bind_int64(stmt, 1, mce->rx_bytes) ||
293293
sqlite3_bind_int64(stmt, 2, mce->tx_bytes) ||
294+
sqlite3_bind_int(stmt, 4, mce->network_address_family) ||
294295
sqlite3_bind_int64(stmt, 6, date_start)) {
295296
META_PRINT_SYSLOG(mws->parent, LOG_ERR, "Failed to bind values to UPDATE usage query\n");
296297
return SQLITE_ERROR;
@@ -299,19 +300,19 @@ static int32_t md_inventory_execute_update_usage(struct md_writer_sqlite *mws,
299300
if (mce->imei) {
300301
if (sqlite3_bind_text(stmt, 3, mce->imei, strlen(mce->imei),
301302
SQLITE_STATIC) ||
302-
sqlite3_bind_text(stmt, 4, mce->interface_id,
303+
sqlite3_bind_text(stmt, 5, mce->interface_id,
303304
strlen(mce->interface_id), SQLITE_STATIC) ||
304-
sqlite3_bind_text(stmt, 5, mce->imsi,
305+
sqlite3_bind_text(stmt, 6, mce->imsi,
305306
strlen(mce->imsi), SQLITE_STATIC)) {
306307
META_PRINT_SYSLOG(mws->parent, LOG_ERR, "Failed to bind values to UPDATE usage query #2\n");
307308
return SQLITE_ERROR;
308309
}
309310
} else {
310311
if (sqlite3_bind_text(stmt, 3, mce->interface_id,
311312
strlen(mce->interface_id), SQLITE_STATIC) ||
312-
sqlite3_bind_text(stmt, 4, no_iccid_str,
313-
strlen(no_iccid_str), SQLITE_STATIC) ||
314313
sqlite3_bind_text(stmt, 5, no_iccid_str,
314+
strlen(no_iccid_str), SQLITE_STATIC) ||
315+
sqlite3_bind_text(stmt, 6, no_iccid_str,
315316
strlen(no_iccid_str), SQLITE_STATIC)) {
316317
META_PRINT_SYSLOG(mws->parent, LOG_ERR, "Failed to bind values to UPDATE usage query #2\n");
317318
return SQLITE_ERROR;

metadata_writer_sqlite.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@
187187
#define UPDATE_USAGE "UPDATE DataUse SET " \
188188
"RxData = RxData + ?, TxData = TxData + ? " \
189189
"WHERE " \
190-
"DeviceId=? AND SimCardIccid=? AND SimCardImsi=? AND Timestamp=?"
190+
"DeviceId=? AND NetworkAddressFamily=? AND SimCardIccid=? AND SimCardImsi=? AND Timestamp=?"
191191

192192
#define UPDATE_EVENT_ID "UPDATE NetworkEvent SET " \
193193
"NodeId=? "\

0 commit comments

Comments
 (0)