Add cognitoAuthenticated getter to determine whether session is active #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kesor Just curious, is this repo still maintained? I'd like to contribute, but only if PRs will actually get reviewed and merged. |
Contributor
|
@ffxsam yes, but at the moment I don't have enough time to add unit tests to PRs. and I don't want to merge commits without unit tests. |
kesor
requested changes
Jan 29, 2018
Contributor
kesor
left a comment
kesor
left a comment
There was a problem hiding this comment.
it does look okay, but will not be merged without unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is impossible to determine if a session has timed out.
This adds a getter that validates the session expiration against the current time.
amazon-cognito-identity-js uses the cognitoSession class to do this, which would be ideal, but I think this approach works.