Skip to content

Conversation

@jmeo
Copy link

@jmeo jmeo commented Jul 29, 2017

update the set action and test do

@coveralls
Copy link

coveralls commented Jul 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2d9c11e on jmeo:master into 7e4940a on koajs:master.

@DaAwesomeP
Copy link
Collaborator

Thank you for the pull! I cannot test it at the moment, but I will as soon as I am in front of my computer again.

I like how you store the TTL on the object. For backwards compatibility, would you mind adding another parameter to the get function (i.e get(sid, ttl)? If TTL is undefined or false, the session will not be reset, but if it is true, then the stored original TTL will used. In a later major version update, this option can be true by default.

@DaAwesomeP
Copy link
Collaborator

@jmeo any updates?

@insidewhy
Copy link
Contributor

@DaAwesomeP @jmeo The correct way to do this is via redis-session's rolling and maxAge parameters now.

@insidewhy
Copy link
Contributor

Published koa-redis-snowman with the correct support for this (and also koa-session support). Happy to merge upstream if the maintainers come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants