Skip to content

fix e2e shell script error #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmesh-bot merged 1 commit into from
Nov 27, 2025
Merged

fix e2e shell script error #1527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ if [ $EXIT_CODE -ne 0 ]; then
cat $LOGFILE
fi

rm rf $LOGFILE
rm -rf $LOGFILE
Copy link

@gemini-code-assist gemini-code-assist bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While the fix to use rm -rf is correct, it's a good practice to quote variable expansions like $LOGFILE. This prevents potential issues if the filename were to contain spaces or special characters in the future.

Suggested change
rm -rf $LOGFILE
rm -rf "$LOGFILE"


if [[ -n ${CLEANUP_KIND} ]]; then
cleanup_kind_cluster
Expand Down
Loading