Merge pull request #1368 from hzxuzhonghu/fix-accesslog-regression

Skip output accesslog on connection establishment

Author: kmesh-bot

docs/proposal/tcp_long_connection_metrics.md

@@ -32,7 +32,7 @@ documentation such as release notes or a development roadmap.
 A good summary is probably at least a paragraph in length.
 -->
 
-Currently kmesh provides access logs during termination and establisment of a TCP connection with more detailed information about the connection, such as bytes sent, received, packet lost, rtt and retransmits.
+Currently kmesh provides access logs after close of a TCP connection with more detailed information about the connection, such as bytes sent, received, packet lost, rtt and retransmits.
 
 Kmesh also provides workload and service specific metrics such as bytes sent and received, lost packets, minimum rtt, total connection opened and closed by a pod, These metrics are only updated after a connection is closed. In this proposal we are aiming to update these metrics periodically.
 

pkg/controller/telemetry/accesslog.go

@@ -78,6 +78,10 @@ func (l *logInfo) withDestinationService(service *workloadapi.Service) *logInfo
 }
 
 func OutputAccesslog(data requestMetric, conn_metrics connMetric, accesslog logInfo) {
+	// Skip output access log on connection establishment
+	if data.state == TCP_ESTABLISHED && data.duration < LONG_CONN_METRIC_THRESHOLD {
+		return
+	}
 	logStr := buildAccesslog(data, conn_metrics, accesslog)
 	fmt.Println("accesslog:", logStr)
 }

pkg/controller/telemetry/metric.go

@@ -48,7 +48,7 @@ const (
 
 	DEFAULT_UNKNOWN = "-"
 
-	LONG_CONN_METRIC_THRESHOLD = uint64(30 * time.Second)
+	LONG_CONN_METRIC_THRESHOLD = uint64(5 * time.Second)
 )
 
 var osStartTime time.Time
@@ -512,7 +512,7 @@ func (m *MetricController) Run(ctx context.Context, mapOfTcpInfo *ebpf.Map) {
 				connectionLabels = m.buildConnectionMetric(&data)
 			}
 			if m.EnableAccesslog.Load() {
-				// accesslogs at start of connection, at interval of 5 sec during connection lifecycle and at close of connection
+				// accesslogs at interval of 5 sec during connection lifecycle and at close of connection
 				OutputAccesslog(data, tcpConns[data.conSrcDstInfo], accesslog)
 			}