Skip to content

Commit e8b18fe

Browse files
Merge pull request #12 from kleros/review/megalite
docs: fix pinakion naming
2 parents 308dbc5 + 3116c51 commit e8b18fe

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ MetaMask setup for Sokol:
1010
- Symbol: SPOA
1111
- Block Explorer URL: https://blockscout.com/poa/sokol
1212

13+
In order to execute transactions on Sokol, you will need the native currency SPOA. Request some in the Sokol [faucet](https://faucet-sokol.herokuapp.com/).
14+
1315
## Deployed Addresses
1416

1517
Sokol:

contracts/kleros/xKlerosLiquid.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* https://contributing.kleros.io/smart-contract-workflow
33
* @authors: [@fnanni-0]
4-
* @reviewers: [@shalzz*, @unknownunknown1*, @MerlinEgalite*, @hbarcelos]
4+
* @reviewers: [@shalzz*, @unknownunknown1*, @MerlinEgalite, @hbarcelos]
55
* @auditors: []
66
* @bounties: []
77
* @deployments: []

contracts/tokens/WrappedPinakion.sol

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* https://contributing.kleros.io/smart-contract-workflow
33
* @authors: [@fnanni-0]
4-
* @reviewers: [@unknownunknown1*, @MerlinEgalite*, @hbarcelos*, @shalzz*]
4+
* @reviewers: [@unknownunknown1*, @MerlinEgalite, @hbarcelos*, @shalzz*]
55
* @auditors: []
66
* @bounties: []
77
* @deployments: []
@@ -51,7 +51,7 @@ contract WrappedPinakion is Initializable {
5151
/// @notice The token's controller.
5252
address public controller;
5353

54-
/// @notice Pinakion on xDai to be wrapped. This token is upgradeable.
54+
/// @notice Bridged PNK on xDai to be wrapped. This token is upgradeable.
5555
IERC677 public xPinakion;
5656

5757
/// @notice xDai Token Bridge. The Token Bridge is upgradeable.
@@ -69,9 +69,9 @@ contract WrappedPinakion is Initializable {
6969

7070
/**
7171
* @dev Constructor.
72-
* @param _name for the wrapped Pinakion on the home chain.
73-
* @param _symbol for wrapped Pinakion ticker on the home chain.
74-
* @param _xPinakion the home pinakion contract which is already bridged to the foreign pinakion contract.
72+
* @param _name for the wrapped PNK on the home chain.
73+
* @param _symbol for wrapped PNK ticker on the home chain.
74+
* @param _xPinakion the home PNK contract which is already bridged to the foreign PNK contract.
7575
* @param _tokenBridge the TokenBridge contract.
7676
*/
7777
function initialize(
@@ -100,7 +100,7 @@ contract WrappedPinakion is Initializable {
100100
}
101101

102102
/**
103-
* @notice Converts bridged pinakions into pinakions which can be staked in KlerosLiquid.
103+
* @notice Converts bridged PNK (xPinakion) into wrapped PNK which can be staked in KlerosLiquid.
104104
* @param _amount The amount of wrapped pinakions to mint.
105105
*/
106106
function deposit(uint256 _amount) external {
@@ -117,8 +117,9 @@ contract WrappedPinakion is Initializable {
117117
* If the tokenBridge is calling this function, then this contract has already received
118118
* the xPinakion tokens.
119119
* @param _token The token address the _amount belongs to.
120-
* @param _amount The amount of wrapped pinakions to mint.
121-
* @param _data Calldata containing the address of the recipient. Notice that the address has to be padded to 32 bytes.
120+
* @param _amount The amount of wrapped PNK to mint.
121+
* @param _data Calldata containing the address of the recipient.
122+
* Notice that the address has to be padded to the right 32 bytes.
122123
*/
123124
function onTokenBridged(
124125
address _token,
@@ -136,20 +137,20 @@ contract WrappedPinakion is Initializable {
136137
}
137138

138139
/**
139-
* @notice Withdraws bridged pinakions.
140-
* @param _amount The amount of bridged pinakions to withdraw.
140+
* @notice Converts wrapped PNK back into bridged PNK (xPinakion).
141+
* @param _amount The amount of bridged PNK to withdraw.
141142
*/
142143
function withdraw(uint256 _amount) external {
143144
_burn(_amount);
144145
require(xPinakion.transfer(msg.sender, _amount), "The `transfer` function must not fail.");
145146
}
146147

147148
/**
148-
* @notice Withdraws the WrappedPinakion and transfers it through the Token Bridge.
149+
* @notice Converts wrapped PNK back into PNK using the Token Bridge.
149150
* @dev This function is not strictly needed, but it provides a good UX to users who want to get their Mainnet's PNK back.
150151
* What normally takes 3 transactions, here is done in one go.
151-
* Notice that the PNK have to be claimed on mainnet's TokenBride by the receiver.
152-
* @param _amount The amount of bridged pinakions to withdraw.
152+
* Notice that the PNK have to be claimed on Mainnet's TokenBridge by the receiver.
153+
* @param _amount The amount of PNK to withdraw.
153154
* @param _receiver The address which will receive the PNK back in the foreign chain.
154155
*/
155156
function withdrawAndConvertToPNK(uint256 _amount, address _receiver) external {

0 commit comments

Comments
 (0)