fix: removed SafeSend from ruler and university, natspec tweaks, SafeSend solidity version

Author: jaybuidl

contracts/deploy/00-home-chain-arbitration-ruler.ts

@@ -32,7 +32,6 @@ const deployArbitration: DeployFunction = async (hre: HardhatRuntimeEnvironment)
       deployer, // governor
       pnk.target,
       [minStake, alpha, feeForJuror, jurorsForCourtJump],
-      weth.target,
     ],
     log: true,
   });

contracts/deploy/00-home-chain-arbitration-university.ts

@@ -59,7 +59,6 @@ const deployArbitration: DeployFunction = async (hre: HardhatRuntimeEnvironment)
       [minStake, alpha, feeForJuror, jurorsForCourtJump],
       [0, 0, 0, 10], // evidencePeriod, commitPeriod, votePeriod, appealPeriod
       sortitionModule.address,
-      weth.target,
     ],
     log: true,
   }); // nonce+2 (implementation), nonce+3 (proxy)

contracts/src/arbitration/KlerosCore.sol

@@ -30,7 +30,7 @@ contract KlerosCore is KlerosCoreBase {
     /// @param _timesPerPeriod The `timesPerPeriod` property value of the general court.
     /// @param _sortitionExtraData The extra data for sortition module.
     /// @param _sortitionModuleAddress The sortition module responsible for sortition of the jurors.
-    /// @param _wNative The address for WETH tranfers.
+    /// @param _wNative The wrapped native token address, typically wETH.
     function initialize(
         address _governor,
         address _guardian,

contracts/src/arbitration/KlerosCoreBase.sol

@@ -101,7 +101,7 @@ abstract contract KlerosCoreBase is IArbitratorV2, Initializable, UUPSProxiable
     Dispute[] public disputes; // The disputes.
     mapping(IERC20 => CurrencyRate) public currencyRates; // The price of each token in ETH.
     bool public paused; // Whether asset withdrawals are paused.
-    address public wNative; // The address for WETH tranfers.
+    address public wNative; // The wrapped native token for safeSend().
 
     // ************************************* //
     // *              Events               * //

contracts/src/arbitration/KlerosCoreNeo.sol

@@ -39,7 +39,7 @@ contract KlerosCoreNeo is KlerosCoreBase {
     /// @param _sortitionExtraData The extra data for sortition module.
     /// @param _sortitionModuleAddress The sortition module responsible for sortition of the jurors.
     /// @param _jurorNft NFT contract to vet the jurors.
-    /// @param _wNative The address for WETH tranfers.
+    /// @param _wNative The wrapped native token address, typically wETH.
     function initialize(
         address _governor,
         address _guardian,

contracts/src/arbitration/KlerosGovernor.sol

@@ -9,6 +9,7 @@ import "./interfaces/IDisputeTemplateRegistry.sol";
 /// @title KlerosGovernor for V2. Note that appeal functionality and evidence submission will be handled by the court.
 contract KlerosGovernor is IArbitrableV2 {
     using SafeSend for address payable;
+
     // ************************************* //
     // *         Enums / Structs           * //
     // ************************************* //
@@ -48,6 +49,7 @@ contract KlerosGovernor is IArbitrableV2 {
 
     IArbitratorV2 public arbitrator; // Arbitrator contract.
     bytes public arbitratorExtraData; // Extra data for arbitrator.
+    address public wNative; // The wrapped native token for safeSend().
     IDisputeTemplateRegistry public templateRegistry; // The dispute template registry.
     uint256 public templateId; // The current dispute template identifier.
 
@@ -62,8 +64,6 @@ contract KlerosGovernor is IArbitrableV2 {
     Submission[] public submissions; // Stores all created transaction lists. submissions[_listID].
     Session[] public sessions; // Stores all submitting sessions. sessions[_session].
 
-    address public wNative; // The address for WETH tranfers.
-
     // ************************************* //
     // *        Function Modifiers         * //
     // ************************************* //
@@ -115,7 +115,7 @@ contract KlerosGovernor is IArbitrableV2 {
     /// @param _submissionTimeout Time in seconds allocated for submitting transaction list.
     /// @param _executionTimeout Time in seconds after approval that allows to execute transactions of the approved list.
     /// @param _withdrawTimeout Time in seconds after submission that allows to withdraw submitted list.
-    /// @param _wNative The address of the WETH used by SafeSend for fallback transfers.
+    /// @param _wNative The wrapped native token address, typically wETH.
     constructor(
         IArbitratorV2 _arbitrator,
         bytes memory _arbitratorExtraData,

contracts/src/arbitration/devtools/KlerosCoreRuler.sol

@@ -4,7 +4,6 @@ pragma solidity ^0.8.24;
 
 import {IArbitrableV2, IArbitratorV2} from "../interfaces/IArbitratorV2.sol";
 import {SafeERC20, IERC20} from "../../libraries/SafeERC20.sol";
-import {SafeSend} from "../../libraries/SafeSend.sol";
 import {UUPSProxiable} from "../../proxy/UUPSProxiable.sol";
 import {Initializable} from "../../proxy/Initializable.sol";
 import "../../libraries/Constants.sol";
@@ -13,7 +12,6 @@ import "../../libraries/Constants.sol";
 /// Core arbitrator contract for development and testing purposes.
 contract KlerosCoreRuler is IArbitratorV2, UUPSProxiable, Initializable {
     using SafeERC20 for IERC20;
-    using SafeSend for address payable;
 
     string public constant override version = "0.8.0";
 
@@ -95,7 +93,6 @@ contract KlerosCoreRuler is IArbitratorV2, UUPSProxiable, Initializable {
     mapping(IArbitrableV2 arbitrable => address ruler) public rulers; // The ruler of each arbitrable contract.
     mapping(IArbitrableV2 arbitrable => RulerSettings) public settings; // The settings of each arbitrable contract.
     mapping(uint256 disputeID => RulingResult) public rulingResults; // The ruling results of each dispute.
-    address public wNative; // The address for WETH tranfers.
 
     // ************************************* //
     // *              Events               * //
@@ -178,16 +175,13 @@ contract KlerosCoreRuler is IArbitratorV2, UUPSProxiable, Initializable {
     /// @param _governor The governor's address.
     /// @param _pinakion The address of the token contract.
     /// @param _courtParameters Numeric parameters of General court (minStake, alpha, feeForJuror and jurorsForCourtJump respectively).
-    /// @param _wNative The address of the WETH used by SafeSend for fallback transfers.
     function initialize(
         address _governor,
         IERC20 _pinakion,
-        uint256[4] memory _courtParameters,
-        address _wNative
+        uint256[4] memory _courtParameters
     ) external reinitializer(1) {
         governor = _governor;
         pinakion = _pinakion;
-        wNative = _wNative;
 
         // FORKING_COURT
         // TODO: Fill the properties for the Forking court, emit CourtCreated.
@@ -531,7 +525,7 @@ contract KlerosCoreRuler is IArbitratorV2, UUPSProxiable, Initializable {
         round.sumFeeRewardPaid += feeReward;
         if (round.feeToken == NATIVE_CURRENCY) {
             // The dispute fees were paid in ETH
-            payable(account).safeSend(feeReward, wNative);
+            payable(account).send(feeReward);
         } else {
             // The dispute fees were paid in ERC20
             round.feeToken.safeTransfer(account, feeReward);

contracts/src/arbitration/dispute-kits/DisputeKitClassic.sol

@@ -25,7 +25,7 @@ contract DisputeKitClassic is DisputeKitClassicBase {
     /// @dev Initializer.
     /// @param _governor The governor's address.
     /// @param _core The KlerosCore arbitrator.
-    /// @param _wNative The address for WETH tranfers.
+    /// @param _wNative The wrapped native token address, typically wETH.
     function initialize(address _governor, KlerosCore _core, address _wNative) external reinitializer(1) {
         __DisputeKitClassicBase_initialize(_governor, _core, _wNative);
     }

contracts/src/arbitration/dispute-kits/DisputeKitClassicBase.sol

@@ -15,6 +15,7 @@ import {SafeSend} from "../../libraries/SafeSend.sol";
 /// - an appeal system: fund 2 choices only, vote on any choice.
 abstract contract DisputeKitClassicBase is IDisputeKit, Initializable, UUPSProxiable {
     using SafeSend for address payable;
+
     // ************************************* //
     // *             Structs               * //
     // ************************************* //
@@ -66,7 +67,7 @@ abstract contract DisputeKitClassicBase is IDisputeKit, Initializable, UUPSProxi
     mapping(uint256 localDisputeID => mapping(uint256 localRoundID => mapping(address drawnAddress => bool)))
         public alreadyDrawn; // True if the address has already been drawn, false by default. To be added to the Round struct when fully redeploying rather than upgrading.
     mapping(uint256 coreDisputeID => bool) public coreDisputeIDToActive; // True if this dispute kit is active for this core dispute ID.
-    address public wNative; // The address for WETH tranfers.
+    address public wNative; // The wrapped native token for safeSend().
 
     // ************************************* //
     // *              Events               * //
@@ -145,7 +146,7 @@ abstract contract DisputeKitClassicBase is IDisputeKit, Initializable, UUPSProxi
     /// @dev Initializer.
     /// @param _governor The governor's address.
     /// @param _core The KlerosCore arbitrator.
-    /// @param _wNative The address for WETH tranfers.
+    /// @param _wNative The wrapped native token address, typically wETH.
     function __DisputeKitClassicBase_initialize(
         address _governor,
         KlerosCore _core,
@@ -463,7 +464,7 @@ abstract contract DisputeKitClassicBase is IDisputeKit, Initializable, UUPSProxi
         round.contributions[_beneficiary][_choice] = 0;
 
         if (amount != 0) {
-            _beneficiary.safeSend(amount, wNative); // Deliberate use of send to prevent reverting fallback. It's the user's responsibility to accept ETH.
+            _beneficiary.safeSend(amount, wNative);
             emit Withdrawal(_coreDisputeID, _coreRoundID, _choice, _beneficiary, amount);
         }
     }

contracts/src/arbitration/dispute-kits/DisputeKitGated.sol

@@ -41,7 +41,7 @@ contract DisputeKitGated is DisputeKitClassicBase {
     /// @dev Initializer.
     /// @param _governor The governor's address.
     /// @param _core The KlerosCore arbitrator.
-    /// @param _wNative The address for WETH tranfers.
+    /// @param _wNative The wrapped native token address, typically wETH.
     function initialize(address _governor, KlerosCore _core, address _wNative) external reinitializer(1) {
         __DisputeKitClassicBase_initialize(_governor, _core, _wNative);
     }