Skip to content

Commit 06cccaa

Browse files
committed
refactor: minor improvement to the DisputeResolver
1 parent 45bcd0f commit 06cccaa

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

contracts/src/arbitration/arbitrables/DisputeResolver.sol

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,22 @@ contract DisputeResolver is IArbitrableV2 {
3030
DisputeStruct[] public disputes; // Local disputes.
3131
mapping(uint256 => uint256) public arbitratorDisputeIDToLocalID; // Maps arbitrator-side dispute IDs to local dispute IDs.
3232

33+
// ************************************* //
34+
// * Function Modifiers * //
35+
// ************************************* //
36+
37+
modifier onlyByOwner() {
38+
if (owner != msg.sender) revert OwnerOnly();
39+
_;
40+
}
41+
3342
// ************************************* //
3443
// * Constructor * //
3544
// ************************************* //
3645

3746
/// @notice Constructor
3847
/// @param _arbitrator Target global arbitrator for any disputes.
48+
/// @param _templateRegistry The dispute template registry.
3949
constructor(IArbitratorV2 _arbitrator, IDisputeTemplateRegistry _templateRegistry) {
4050
owner = msg.sender;
4151
arbitrator = _arbitrator;
@@ -48,18 +58,15 @@ contract DisputeResolver is IArbitrableV2 {
4858

4959
/// @notice Changes the owner.
5060
/// @param _owner The address of the new owner.
51-
function changeOwner(address _owner) external {
52-
if (owner != msg.sender) revert OwnerOnly();
61+
function changeOwner(address _owner) external onlyByOwner {
5362
owner = _owner;
5463
}
5564

56-
function changeArbitrator(IArbitratorV2 _arbitrator) external {
57-
if (owner != msg.sender) revert OwnerOnly();
65+
function changeArbitrator(IArbitratorV2 _arbitrator) external onlyByOwner {
5866
arbitrator = _arbitrator;
5967
}
6068

61-
function changeTemplateRegistry(IDisputeTemplateRegistry _templateRegistry) external {
62-
if (owner != msg.sender) revert OwnerOnly();
69+
function changeTemplateRegistry(IDisputeTemplateRegistry _templateRegistry) external onlyByOwner {
6370
templateRegistry = _templateRegistry;
6471
}
6572

0 commit comments

Comments
 (0)