Merge pull request #365 from unknownunknown1/fix/rng

unknownunknown1 · web-flow · commit e54f3323235d · 2022-09-06T00:34:41.000+10:00
fix(RNG): precise comparison
diff --git a/contracts/standard/rng/BeaconRNG.sol b/contracts/standard/rng/BeaconRNG.sol
@@ -48,7 +48,7 @@ contract BeaconRNG {
             }
         // Post-Merge.
         } else {
-            if (block.number > _block && (block.number - _block) % (LOOKAHEAD + ERROR) > LOOKAHEAD) {
+            if (block.number > _block && (block.number - _block) % (LOOKAHEAD + ERROR) >= LOOKAHEAD) {
                 // Eligible block number should exceed LOOKAHEAD but shouldn't be higher than LOOKAHEAD + ERROR.
                 // In case of the latter LOOKAHEAD gets reset.  
                 return uint(keccak256(abi.encodePacked(msg.sender, block.difficulty)));

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ contract BeaconRNG {`
`48`	`48`	`}`
`49`	`49`	`// Post-Merge.`
`50`	`50`	`} else {`
`51`		`- if (block.number > _block && (block.number - _block) % (LOOKAHEAD + ERROR) > LOOKAHEAD) {`
	`51`	`+ if (block.number > _block && (block.number - _block) % (LOOKAHEAD + ERROR) >= LOOKAHEAD) {`
`52`	`52`	`// Eligible block number should exceed LOOKAHEAD but shouldn't be higher than LOOKAHEAD + ERROR.`
`53`	`53`	`// In case of the latter LOOKAHEAD gets reset.`
`54`	`54`	`return uint(keccak256(abi.encodePacked(msg.sender, block.difficulty)));`