Skip to content

Commit 428af6e

Browse files
committed
Constructor check removed, specified access specifier & updated return parameter for functions
1 parent dd27f17 commit 428af6e

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

contracts/standard/arbitration/MultipleArbitrableTransactionWithFee.sol

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ contract MultipleArbitrableTransactionWithFee is IArbitrable {
110110
uint _feeRecipientBasisPoint,
111111
uint _feeTimeout
112112
) public {
113-
require(_feeRecipientBasisPoint < 10001, "Value of percentage to be in the range [0, 10000]");
114113
arbitrator = _arbitrator;
115114
arbitratorExtraData = _arbitratorExtraData;
116115
feeRecipient = _feeRecipient;
@@ -149,21 +148,19 @@ contract MultipleArbitrableTransactionWithFee is IArbitrable {
149148
/** @dev Calculate the amount to be paid in wei according to feeRecipientBasisPoint for a particular amount.
150149
* @param _amount Amount to pay in wei.
151150
*/
152-
function calculateFeeRecipientAmount(uint _amount) internal returns(uint feeAmount){
151+
function calculateFeeRecipientAmount(uint _amount) internal view returns(uint feeAmount){
153152
feeAmount = (_amount * feeRecipientBasisPoint) / 10000;
154153
}
155154

156155
/** @dev Change Fee Recipient.
157156
* @param _newFeeRecipient Address of the new Fee Recipient.
158157
* @return _status true when suceessful, false otherwise.
159158
*/
160-
function changeFeeRecipient(address _newFeeRecipient) public returns(bool _status){
159+
function changeFeeRecipient(address _newFeeRecipient) public {
161160
require(msg.sender == feeRecipient, "The caller must be the current Fee Recipient");
162161
feeRecipient = _newFeeRecipient;
163162

164163
emit FeeRecipientChanged(msg.sender, _newFeeRecipient);
165-
166-
return true;
167164
}
168165

169166
/** @dev Pay receiver. To be called if the good or service is provided.

0 commit comments

Comments
 (0)