refactor: simplify shownOptions

Author: greenlucid

src/components/light-search-bar.js

@@ -209,11 +209,11 @@ const LightSearchBar = () => {
   const onChange = itemID => setValue(itemID)
 
   const shownOptions = () => {
-    if ((writing || itemSearchQuery.loading) && !empty)
+    if (empty) return []
+    if (writing || itemSearchQuery.loading)
       return <Select.Option key="Loading">Loading...</Select.Option>
-    if (!writing && options.length === 0 && !empty)
+    if (!writing && options.length === 0)
       return <Select.Option key="NoResult">No results</Select.Option>
-    if (empty) return []
     else return options
   }
 

src/components/search-bar.js

@@ -301,11 +301,10 @@ const SearchBar = () => {
   const onChange = useCallback(itemID => setValue(itemID), [])
 
   const shownOptions = () => {
-    if (writing && !empty)
-      return <Select.Option key="Loading">Loading...</Select.Option>
-    if (!writing && options.length === 0 && !empty)
-      return <Select.Option key="NoResult">No results</Select.Option>
     if (empty) return []
+    if (writing) return <Select.Option key="Loading">Loading...</Select.Option>
+    if (!writing && options.length === 0)
+      return <Select.Option key="NoResult">No results</Select.Option>
     else return options
   }