replace the command names in the git-rebase-todo file as well (keep in sync / source of truth)

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>

Author: kiprasmel

git-stacked-rebase.ts

@@ -26,6 +26,7 @@ import {
 	GoodCommandStacked, //
 	namesOfRebaseCommandsThatMakeRebaseExitToPause,
 	StackedRebaseCommand,
+	StackedRebaseEitherCommandOrAlias,
 } from "./parse-todo-of-stacked-rebase/validator";
 
 // console.log = () => {};
@@ -591,18 +592,37 @@ export const gitStackedRebase = async (
 			await repo.checkoutBranch(newLatestBranchCmd.targets![0]);
 
 			/**
-			 * TODO update in the actual `git-rebase-todo` file
+			 * need to change to "branch-end", instead of "branch-end-new",
+			 * since obviously the branch already exists
 			 */
+			oldLatestBranchCmd.commandName = "branch-end";
+			oldLatestBranchCmd.commandOrAliasName = "branch-end";
+
+			newLatestBranchCmd.commandName = "branch-end-last";
+			newLatestBranchCmd.commandOrAliasName = "branch-end-last";
 
 			/**
-			 * need to change to "branch-end", instead of "branch-end-new",
-			 * since obviously the branch already exists
+			 * TODO FIXME don't do this so hackishly lmao
 			 */
-			goodCommands[oldLatestBranchCmdIndex].commandName = "branch-end";
-			goodCommands[oldLatestBranchCmdIndex].commandOrAliasName = "branch-end";
+			const editedRebaseTodo: string = fs.readFileSync(pathToStackedRebaseTodoFile, { encoding: "utf-8" });
+			const linesOfEditedRebaseTodo: string[] = editedRebaseTodo.split("\n");
+
+			replaceCommandInText(oldLatestBranchCmd, "branch-end-last", "branch-end");
+			replaceCommandInText(newLatestBranchCmd, "branch-end-new", "branch-end-last");
+
+			// eslint-disable-next-line no-inner-declarations
+			function replaceCommandInText(
+				cmd: GoodCommandStacked, //
+				expectedOldName: StackedRebaseEitherCommandOrAlias,
+				newName: StackedRebaseCommand
+			): void {
+				const words = linesOfEditedRebaseTodo[cmd.lineNumber].split(" ");
+				assert.equal(words[0], expectedOldName);
+				words[0] = newName;
+				linesOfEditedRebaseTodo[oldLatestBranchCmd.lineNumber] = words.join(" ");
+			}
 
-			goodCommands[newLatestBranchCmdIndex].commandName = "branch-end-last";
-			goodCommands[newLatestBranchCmdIndex].commandOrAliasName = "branch-end-last";
+			fs.writeFileSync(pathToStackedRebaseTodoFile, linesOfEditedRebaseTodo.join("\n"), { encoding: "utf-8" });
 
 			/**
 			 * it's fine if the new "latest branch" does not have

parse-todo-of-stacked-rebase/validator.ts

@@ -144,6 +144,7 @@ export const regularRebaseCommands = {
 } as const;
 
 export type RegularRebaseCommand = keyof typeof regularRebaseCommands;
+export type RegularRebaseEitherCommandOrAlias = RegularRebaseCommand | RegularRebaseCommandAlias;
 
 /**
  * TODO: assert each value is `RegularRebaseCommand`,
@@ -227,8 +228,12 @@ const stackedRebaseCommandAliases = {
 	ben: "branch-end-new",
 } as const;
 
-type StackedRebaseCommandAlias = keyof typeof stackedRebaseCommandAliases;
+export type StackedRebaseCommandAlias = keyof typeof stackedRebaseCommandAliases;
+export type StackedRebaseEitherCommandOrAlias = StackedRebaseCommand | StackedRebaseCommandAlias;
 
+/**
+ * combined
+ */
 export type EitherRebaseCommand = RegularRebaseCommand | StackedRebaseCommand;
 export type EitherRebaseCommandAlias = RegularRebaseCommandAlias | StackedRebaseCommandAlias;