Skip to content

Commit 2d15e34

Browse files
committed
ci: test more node versions (16, 18), fix test result badge in README
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
1 parent 9dc430c commit 2d15e34

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

.github/workflows/test.yml

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,36 +12,32 @@ jobs:
1212
fail-fast: false
1313
matrix:
1414
os: [ubuntu-latest, macos-latest]
15-
node: [12, 14]
15+
node: [12, 14, 16, 18]
1616
experimental: [false]
1717
exclude:
1818
- os: macos-latest
1919
node: 12
20+
21+
# nodegit binary missing...
22+
#
23+
# e.g. https://github.com/kiprasmel/git-stacked-rebase/actions/runs/4606760208/jobs/8140453365
24+
#
25+
# ```
26+
# install response status 404 Not Found on
27+
# https://axonodegit.s3.amazonaws.com/nodegit/nodegit/nodegit-v0.28.0-alpha.18-node-v108-linux-x64.tar.gz
28+
# ```
29+
#
30+
# see also:
31+
# - https://github.com/nodegit/nodegit/issues/1840#issuecomment-943083741
32+
# - https://github.com/nodegit/nodegit/issues/1840#issuecomment-1302139622
33+
- os: ubuntu-latest
34+
node: 18
2035
include:
2136
# test macos - for some reason, internet conn fails @ github actions
2237
- os: macos-latest
2338
node: 12
2439
experimental: true
2540

26-
# - os: ubuntu-latest
27-
# node: 10
28-
# experimental: true
29-
# - os: ubuntu-latest
30-
# # v16 should work fine; there're some issues in CI with `krb5-config`
31-
# node: 16
32-
# experimental: true
33-
# - os: ubuntu-latest
34-
# node: 18
35-
# experimental: true
36-
37-
# # test windows, w/ wanted versions
38-
# - os: windows-latest
39-
# node: 12
40-
# experimental: true
41-
# - os: windows-latest
42-
# node: 14
43-
# experimental: true
44-
4541
steps:
4642
- uses: actions/checkout@v2
4743
- uses: actions/setup-node@v3

README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ dependencies:
4747
- git
4848
- a unix-like environment
4949
- [node.js](https://nodejs.org/en/)
50-
- yarn (`npm i -g yarn`)
50+
- tested versions: 12 thru 18, except v18 on linux. [see details](https://github.com/kiprasmel/git-stacked-rebase/blob/refactor1/.github/workflows/test.yml).
51+
- note that after installing node, you can install version managers, e.g. `npm i -g n`, to easily change node's version.
52+
- yarn (`npm i -g yarn`)
5153

5254
<!-- REMOVED because i'm dogfooding like never before. use nightly instead. -->
5355
<!--
@@ -59,6 +61,8 @@ git config --global alias.rr git-stacked-rebase
5961
```
6062
-->
6163

64+
once satisfied, run:
65+
6266
```sh
6367
git clone https://github.com/kiprasmel/git-stacked-rebase
6468
# or: git clone git@github.com:kiprasmel/git-stacked-rebase.git
@@ -68,7 +72,7 @@ cd git-stacked-rebase
6872
./nightly-setup-and-update.sh
6973
```
7074

71-
[![nightly](https://img.shields.io/github/workflow/status/kiprasmel/git-stacked-rebase/tests/nightly?label=nightly)](https://github.com/kiprasmel/git-stacked-rebase/actions/workflows/test.yml)
75+
[![nightly](https://img.shields.io/github/actions/workflow/status/kiprasmel/git-stacked-rebase/test.yml?label=nightly)](https://github.com/kiprasmel/git-stacked-rebase/actions/workflows/test.yml)
7276

7377
## Usage
7478

0 commit comments

Comments
 (0)