Skip to content

Commit c64f6bf

Browse files
committed
Wait for async tesks in test
1 parent 4103fb5 commit c64f6bf

File tree

3 files changed

+20
-18
lines changed

3 files changed

+20
-18
lines changed

packages/react-native-version-check/src/__tests__/getLatestVersion.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,16 @@ import { getLatestVersion } from '../getLatestVersion';
1010
describe('getLatestVersion', () => {
1111
it('get latest version properly', async () => {
1212
if (process.env.RNVC_DEVICE === 'android') {
13-
getLatestVersion().catch(err => expect(err).toBeDefined());
13+
await getLatestVersion().catch(err => expect(err).toBeDefined());
1414
} else {
15-
getLatestVersion().then(r => expect(typeof +r === 'number').toBeTruthy());
15+
await getLatestVersion().then(r =>
16+
expect(typeof +r === 'number').toBeTruthy()
17+
);
1618
}
1719
});
1820

19-
it('reject with invalid response', () => {
20-
getLatestVersion({
21+
it('reject with invalid response', async () => {
22+
await getLatestVersion({
2123
provider: () => fetch('http://invalid.url/'),
2224
})
2325
.then(() => {

packages/react-native-version-check/src/__tests__/needUpdate.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,48 +8,48 @@ setVersionInfo(VersionInfo);
88
import needUpdate from '../needUpdate';
99

1010
describe('needUpdate', () => {
11-
it('should work well', () => {
12-
needUpdate({
11+
it('should work well', async () => {
12+
await needUpdate({
1313
currentVersion: '2.0',
1414
latestVersion: '10.0',
1515
}).then(res => {
1616
expect(res.isNeeded).toBe(true);
1717
});
1818
});
19-
it('should work well', () => {
20-
needUpdate({
19+
it('should work well', async () => {
20+
await needUpdate({
2121
currentVersion: '10.0',
2222
latestVersion: '10.0',
2323
}).then(res => {
2424
expect(res.isNeeded).toBe(false);
2525
});
2626
});
27-
it("should ignore spare '0' tokens.", () => {
28-
needUpdate({
27+
it("should ignore spare '0' tokens.", async () => {
28+
await needUpdate({
2929
currentVersion: '1.0',
3030
latestVersion: '1.0.0',
3131
}).then(res => {
3232
expect(res.isNeeded).toBe(false);
3333
});
3434
});
35-
it("should ignore spare '0' tokens.", () => {
36-
needUpdate({
35+
it("should ignore spare '0' tokens.", async () => {
36+
await needUpdate({
3737
currentVersion: '1.0.0',
3838
latestVersion: '1.0',
3939
}).then(res => {
4040
expect(res.isNeeded).toBe(false);
4141
});
4242
});
43-
it("should not ignore spare none '0' tokens.", () => {
44-
needUpdate({
43+
it("should not ignore spare none '0' tokens.", async () => {
44+
await needUpdate({
4545
currentVersion: '1.0',
4646
latestVersion: '1.0.1',
4747
}).then(res => {
4848
expect(res.isNeeded).toBe(true);
4949
});
5050
});
51-
it('should return result that update not needed if latest version is lower', () => {
52-
needUpdate({
51+
it('should return result that update not needed if latest version is lower', async () => {
52+
await needUpdate({
5353
currentVersion: '3.0.2',
5454
latestVersion: '2.6.1',
5555
}).then(res => {

packages/react-native-version-check/src/__tests__/versionInfo.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ jest.mock('react-native');
33
import VersionInfo from '../RNVersionInfo';
44

55
describe('Native', () => {
6-
it('Native variables should match', () => {
7-
VersionInfo.getCountry().then(country => expect(country).toBe('ko'));
6+
it('Native variables should match', async () => {
7+
await VersionInfo.getCountry().then(country => expect(country).toBe('ko'));
88
expect(VersionInfo.getPackageName()).toBe('com.reactnative.versioncheck');
99
expect(VersionInfo.getCurrentBuildNumber()).toBe(1);
1010
expect(VersionInfo.getCurrentVersion()).toBe('0.0.1');

0 commit comments

Comments
 (0)