chore: Biome 2 (#330)

* Updating deps

* Biome config update

* Lint fixes

Author: CarlosGamero

biome.json

@@ -1,8 +1,12 @@
 {
     "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+    "root": true,
     "extends": [
-        "./node_modules/@lokalise/biome-config/configs/biome-base.jsonc",
-        "./node_modules/@lokalise/biome-config/configs/biome-esm.jsonc",
-        "./node_modules/@lokalise/biome-config/configs/biome-package.jsonc"
-    ]
+        "@lokalise/biome-config/configs/biome-base.jsonc",
+        "@lokalise/biome-config/configs/biome-esm.jsonc",
+        "@lokalise/biome-config/configs/biome-package.jsonc"
+    ],
+    "files": {
+        "includes": ["**", "!.turbo", "!**/dist", "!**/coverage"]
+    }
 }

examples/sns-sqs/biome.json

@@ -27,8 +27,8 @@
         "zod": "^3.25.7"
     },
     "devDependencies": {
-        "@biomejs/biome": "1.9.4",
-        "@lokalise/biome-config": "^2.0.0",
+        "@biomejs/biome": "^2.2.0",
+        "@lokalise/biome-config": "^3.1.0",
         "@types/node": "^22.15.19",
         "@lokalise/tsconfig": "^1.3.0",
         "@vitest/coverage-v8": "^3.1.4",

examples/sns-sqs/package.json

@@ -94,7 +94,7 @@ export abstract class AbstractAmqpConsumer<
 
     this.queueName = options.locatorConfig
       ? options.locatorConfig.queueName
-      : // biome-ignore lint/style/noNonNullAssertion: <explanation>
+      : // biome-ignore lint/style/noNonNullAssertion: Checked by type
         options.creationConfig!.queueName
 
     this._messageSchemaContainer = this.resolveConsumerMessageSchemaContainer(options)
@@ -151,14 +151,14 @@ export abstract class AbstractAmqpConsumer<
       }
       const { originalMessage, parsedMessage } = deserializedMessage.result
 
-      // @ts-ignore
+      // @ts-expect-error
       const messageType = parsedMessage[this.messageTypeField]
       const transactionSpanId = `queue_${this.queueName}:${
-        // @ts-ignore
+        // @ts-expect-error
         parsedMessage[this.messageTypeField]
       }`
 
-      // @ts-ignore
+      // @ts-expect-error
       const uniqueTransactionKey = parsedMessage[this.messageIdField]
       this.transactionObservabilityManager?.start(transactionSpanId, uniqueTransactionKey)
       if (this.logMessages) {
@@ -349,10 +349,10 @@ export abstract class AbstractAmqpConsumer<
     // Empty content for whatever reason
     if (!resolvedMessage || !resolvedMessage.body) return ABORT_EARLY_EITHER
 
-    // @ts-ignore
+    // @ts-expect-error
     if (this.messageIdField in resolvedMessage.body) {
       return {
-        // @ts-ignore
+        // @ts-expect-error
         result: resolvedMessage.body[this.messageIdField],
       }
     }

packages/amqp/lib/AbstractAmqpConsumer.ts

@@ -1,5 +1,5 @@
 import type { Either } from '@lokalise/node-core'
-import { InternalError, copyWithoutUndefined } from '@lokalise/node-core'
+import { copyWithoutUndefined, InternalError } from '@lokalise/node-core'
 import type {
   BarrierResult,
   CommonCreationConfigType,
@@ -88,7 +88,7 @@ export abstract class AbstractAmqpPublisher<
     }
 
     if (this.logMessages) {
-      // @ts-ignore
+      // @ts-expect-error
       const resolvedLogMessage = this.resolveMessageLog(message, message[this.messageTypeField])
       this.logMessage(resolvedLogMessage)
     }
@@ -110,7 +110,7 @@ export abstract class AbstractAmqpPublisher<
       // Unfortunately, reliable retry mechanism can't be implemented with try-catch block,
       // as not all failures end up here. If connection is closed programmatically, it works fine,
       // but if server closes connection unexpectedly (e. g. RabbitMQ is shut down), then we don't land here
-      // @ts-ignore
+      // @ts-expect-error
       if (err.message === 'Channel closed') {
         this.logger.error('AMQP channel closed')
         void this.reconnect()
@@ -120,10 +120,10 @@ export abstract class AbstractAmqpPublisher<
           errorCode: 'AMQP_PUBLISH_ERROR',
           details: copyWithoutUndefined({
             publisher: this.constructor.name,
-            // @ts-ignore
+            // @ts-expect-error
             queueName: this.queueName,
             exchange: this.exchange,
-            // @ts-ignore
+            // @ts-expect-error
             messageType: message[this.messageTypeField] ?? 'unknown',
           }),
           cause: err as Error,

packages/amqp/lib/AbstractAmqpPublisher.ts

@@ -11,7 +11,7 @@ export class AbstractAmqpQueueConsumer<
       await deleteAmqpQueue(this.channel, this.deletionConfig, this.creationConfig)
     }
 
-    // biome-ignore lint/style/noNonNullAssertion: <explanation>
+    // biome-ignore lint/style/noNonNullAssertion: Should be fine
     await ensureAmqpQueue(this.connection!, this.channel, this.creationConfig, this.locatorConfig)
   }
 }

packages/amqp/lib/AbstractAmqpQueueConsumer.ts

@@ -55,7 +55,7 @@ export abstract class AbstractAmqpQueuePublisher<
   }
 
   protected override createMissingEntities(): Promise<void> {
-    // biome-ignore lint/style/noNonNullAssertion: <explanation>
+    // biome-ignore lint/style/noNonNullAssertion: Should be fine
     return ensureAmqpQueue(this.connection!, this.channel, this.creationConfig, this.locatorConfig)
   }
 }

packages/amqp/lib/AbstractAmqpQueuePublisher.ts

@@ -5,8 +5,7 @@ import type {
   QueueOptions,
 } from '@message-queue-toolkit/core'
 import { AbstractQueueService } from '@message-queue-toolkit/core'
-import type { Channel, ChannelModel, Message } from 'amqplib'
-import type { Options } from 'amqplib'
+import type { Channel, ChannelModel, Message, Options } from 'amqplib'
 import type { AmqpConnectionManager, ConnectionReceiver } from './AmqpConnectionManager.ts'
 
 export type AMQPDependencies = QueueDependencies & {
@@ -61,7 +60,7 @@ export abstract class AbstractAmqpService<
 {
   protected connection?: ChannelModel
   private connectionManager: AmqpConnectionManager
-  // @ts-ignore
+  // @ts-expect-error
   protected channel: Channel
   private isShuttingDown: boolean
 
@@ -87,7 +86,7 @@ export abstract class AbstractAmqpService<
     try {
       this.channel = await this.connection.createChannel()
     } catch (err) {
-      // @ts-ignore
+      // @ts-expect-error
       this.logger.error(`Error creating channel: ${err.message}`)
       await this.connectionManager.reconnect()
       return
@@ -128,7 +127,7 @@ export abstract class AbstractAmqpService<
       } catch (_err) {
         // We don't care about connection closing errors
       } finally {
-        // @ts-ignore
+        // @ts-expect-error
         this.channel = undefined
       }
     }

packages/amqp/lib/AbstractAmqpService.ts

@@ -19,7 +19,7 @@ export class AbstractAmqpTopicConsumer<
     }
 
     await ensureAmqpTopicSubscription(
-      // biome-ignore lint/style/noNonNullAssertion: <explanation>
+      // biome-ignore lint/style/noNonNullAssertion: Should be fine
       this.connection!,
       this.channel,
       this.creationConfig,

packages/amqp/lib/AbstractAmqpTopicConsumer.ts

@@ -48,17 +48,17 @@ export abstract class AbstractAmqpTopicPublisher<
     message: Buffer,
     options: Omit<AmqpTopicMessageOptions, 'routingKey'> & { routingKey: string },
   ): void {
-    // biome-ignore lint/style/noNonNullAssertion: <explanation>
+    // biome-ignore lint/style/noNonNullAssertion: Should be fine
     this.channel.publish(this.exchange!, options.routingKey, message, options.publishOptions)
   }
 
   protected override resolveTopicOrQueue(): string {
-    // biome-ignore lint/style/noNonNullAssertion: <explanation>
+    // biome-ignore lint/style/noNonNullAssertion: Should be fine
     return this.exchange!
   }
 
   protected override async createMissingEntities(): Promise<void> {
-    // biome-ignore lint/style/noNonNullAssertion: <explanation>
+    // biome-ignore lint/style/noNonNullAssertion: Should be fine
     await ensureExchange(this.connection!, this.channel, this.creationConfig, this.locatorConfig)
   }
 }