chore: Fix lint (#350)

CarlosGamero · web-flow · commit 5fbf16aa6d87 · 2025-10-30T16:42:49.000+01:00
* biome update to match CI

* lint fix

* more lint fixes

* More lint fixes

* Test fix

* Lint fix

* More lint fixes
diff --git a/examples/sns-sqs/package.json b/examples/sns-sqs/package.json
@@ -27,7 +27,7 @@
         "zod": "^3.25.7"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@types/node": "^22.15.19",
         "@lokalise/tsconfig": "^1.3.0",
diff --git a/packages/amqp/lib/AbstractAmqpPublisher.ts b/packages/amqp/lib/AbstractAmqpPublisher.ts
@@ -93,7 +93,6 @@ export abstract class AbstractAmqpPublisher<
       this.logMessage(resolvedLogMessage)
     }
 
-    // biome-ignore lint/style/noParameterAssign: it's ok
     message = this.updateInternalProperties(message)
 
     try {
diff --git a/packages/amqp/package.json b/packages/amqp/package.json
@@ -37,7 +37,7 @@
         "zod": ">=3.25.76 <5.0.0"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@message-queue-toolkit/core": "*",
diff --git a/packages/core/lib/events/DomainEventEmitter.spec.ts b/packages/core/lib/events/DomainEventEmitter.spec.ts
@@ -47,7 +47,7 @@ const expectedUpdatedPayload = {
   type: 'entity.updated',
 }
 
-describe('AutopilotEventEmitter', () => {
+describe('DomainEventEmitter', () => {
   let diContainer: AwilixContainer<Dependencies>
   let eventEmitter: DomainEventEmitter<TestEventsType>
 
@@ -412,7 +412,7 @@ describe('AutopilotEventEmitter', () => {
       })
       expect(logSpy).toHaveBeenCalledWith({
         error: expect.anything(),
-        message: 'ErroredFakeListener error',
+        msg: 'ErroredFakeListener error',
         ...expectedContext,
       })
 
diff --git a/packages/core/lib/message-deduplication/messageDeduplicationTypes.ts b/packages/core/lib/message-deduplication/messageDeduplicationTypes.ts
@@ -1,6 +1,6 @@
 import type { Either } from '@lokalise/node-core'
 import type { MessageDeduplicationOptions } from '@message-queue-toolkit/schemas'
-import type { AcquireLockTimeoutError } from './AcquireLockTimeoutError.js'
+import type { AcquireLockTimeoutError } from './AcquireLockTimeoutError.ts'
 
 export interface ReleasableLock {
   release(): Promise<void>
diff --git a/packages/core/lib/queues/AbstractQueueService.ts b/packages/core/lib/queues/AbstractQueueService.ts
@@ -17,7 +17,7 @@ import type { MessageInvalidFormatError, MessageValidationError } from '../error
 import {
   type AcquireLockTimeoutError,
   isAcquireLockTimeoutError,
-} from '../message-deduplication/AcquireLockTimeoutError.js'
+} from '../message-deduplication/AcquireLockTimeoutError.ts'
 import {
   DEFAULT_MESSAGE_DEDUPLICATION_OPTIONS,
   type DeduplicationRequester,
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -37,7 +37,7 @@
         "zod": ">=3.25.76 <5.0.0"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@types/node": "^24.0.3",
diff --git a/packages/kafka/lib/AbstractKafkaConsumer.ts b/packages/kafka/lib/AbstractKafkaConsumer.ts
@@ -38,7 +38,7 @@ import { ILLEGAL_GENERATION, REBALANCE_IN_PROGRESS, UNKNOWN_MEMBER_ID } from './
 import {
   type KafkaMessageBatchOptions,
   KafkaMessageBatchStream,
-} from './utils/KafkaMessageBatchStream.js'
+} from './utils/KafkaMessageBatchStream.ts'
 import { safeJsonDeserializer } from './utils/safeJsonDeserializer.ts'
 
 export type KafkaConsumerDependencies = KafkaDependencies &
diff --git a/packages/kafka/lib/handler-routing/KafkaHandlerConfig.ts b/packages/kafka/lib/handler-routing/KafkaHandlerConfig.ts
@@ -1,5 +1,5 @@
 import type { ZodSchema } from 'zod/v4'
-import type { DeserializedMessage, RequestContext } from '../types.js'
+import type { DeserializedMessage, RequestContext } from '../types.ts'
 
 export type KafkaHandler<
   MessageValue extends object,
diff --git a/packages/kafka/package.json b/packages/kafka/package.json
@@ -61,7 +61,7 @@
         "zod": ">=3.25.76 <5.0.0"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@message-queue-toolkit/core": ">=23.0.0",
diff --git a/packages/metrics/lib/prometheus/metrics/message-time/PrometheusMessageQueueTimeMetric.spec.ts b/packages/metrics/lib/prometheus/metrics/message-time/PrometheusMessageQueueTimeMetric.spec.ts
@@ -2,7 +2,7 @@ import type { ProcessedMessageMetadata } from '@message-queue-toolkit/core'
 import type { Histogram } from 'prom-client'
 import * as promClient from 'prom-client'
 import { describe, expect, it, vi } from 'vitest'
-import { PrometheusMessageQueueTimeMetric } from './PrometheusMessageQueueTimeMetric.js'
+import { PrometheusMessageQueueTimeMetric } from './PrometheusMessageQueueTimeMetric.ts'
 
 type TestMessage = {
   id: string
diff --git a/packages/metrics/package.json b/packages/metrics/package.json
@@ -34,7 +34,7 @@
         "prom-client": ">=15.0.0"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@message-queue-toolkit/core": "*",
diff --git a/packages/outbox-core/package.json b/packages/outbox-core/package.json
@@ -35,7 +35,7 @@
         "@message-queue-toolkit/schemas": ">=7.0.0"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@message-queue-toolkit/core": "*",
diff --git a/packages/redis-message-deduplication-store/package.json b/packages/redis-message-deduplication-store/package.json
@@ -36,7 +36,7 @@
         "ioredis": "^5.3.2"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@message-queue-toolkit/core": "*",
diff --git a/packages/s3-payload-store/package.json b/packages/s3-payload-store/package.json
@@ -38,7 +38,7 @@
     },
     "devDependencies": {
         "@message-queue-toolkit/core": "*",
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@types/node": "^24.0.3",
diff --git a/packages/schemas/lib/events/eventTypes.ts b/packages/schemas/lib/events/eventTypes.ts
@@ -1,6 +1,6 @@
 import { z } from 'zod/v4'
 
-import { MetadataObjectSchema } from '../messages/baseMessageSchemas.js'
+import { MetadataObjectSchema } from '../messages/baseMessageSchemas.ts'
 import { CONSUMER_BASE_EVENT_SCHEMA, PUBLISHER_BASE_EVENT_SCHEMA } from './baseEventSchemas.ts'
 
 export type EventTypeNames<EventDefinition extends CommonEventDefinition> =
diff --git a/packages/schemas/package.json b/packages/schemas/package.json
@@ -29,7 +29,7 @@
         "zod": ">=3.25.67"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@types/node": "^24.0.3",
diff --git a/packages/sns/lib/utils/snsInitter.ts b/packages/sns/lib/utils/snsInitter.ts
@@ -16,7 +16,7 @@ import { isCreateTopicCommand, type TopicResolutionOptions } from '../types/Topi
 import type { SNSSubscriptionOptions } from './snsSubscriber.ts'
 import { subscribeToTopic } from './snsSubscriber.ts'
 import { assertTopic, deleteSubscription, deleteTopic, getTopicAttributes } from './snsUtils.ts'
-import { buildTopicArn } from './stsUtils.js'
+import { buildTopicArn } from './stsUtils.ts'
 
 // biome-ignore lint/complexity/noExcessiveCognitiveComplexity: fixme
 export async function initSnsSqs(
diff --git a/packages/sns/lib/utils/snsSubscriber.ts b/packages/sns/lib/utils/snsSubscriber.ts
@@ -13,7 +13,7 @@ import {
   type TopicResolutionOptions,
 } from '../types/TopicTypes.ts'
 import { assertTopic, findSubscriptionByTopicAndQueue } from './snsUtils.ts'
-import { buildTopicArn } from './stsUtils.js'
+import { buildTopicArn } from './stsUtils.ts'
 
 export type SNSSubscriptionOptions = Omit<
   SubscribeCommandInput,
diff --git a/packages/sns/package.json b/packages/sns/package.json
@@ -44,7 +44,7 @@
         "@aws-sdk/client-s3": "^3.812.0",
         "@aws-sdk/client-sns": "^3.812.0",
         "@aws-sdk/client-sqs": "^3.812.0",
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@message-queue-toolkit/core": "*",
diff --git a/packages/sns/test/consumers/SnsSqsPermissionConsumer.deadLetterQueue.spec.ts b/packages/sns/test/consumers/SnsSqsPermissionConsumer.deadLetterQueue.spec.ts
@@ -226,7 +226,7 @@ describe('SnsSqsPermissionConsumer - dead letter queue', () => {
         queueUrl: consumer.subscriptionProps.deadLetterQueueUrl ?? '',
         handleMessage: (message: SQSMessage) => {
           dlqMessage = message
-          return Promise.resolve()
+          return Promise.resolve(message)
         },
       })
       dlqConsumer.start()
diff --git a/packages/sns/test/consumers/SnsSqsPermissionConsumer.spec.ts b/packages/sns/test/consumers/SnsSqsPermissionConsumer.spec.ts
@@ -451,7 +451,7 @@ describe('SnsSqsPermissionConsumer', () => {
         )
         expect(newConsumer.subscriptionProps.queueName).toBe(queueName)
 
-        expect(attributes.result?.attributes!.Policy).toMatchInlineSnapshot(
+        expect(attributes.result?.attributes?.Policy).toMatchInlineSnapshot(
           `"{"Version":"2012-10-17","Id":"__default_policy_ID","Statement":[{"Sid":"AllowSNSPublish","Effect":"Allow","Principal":{"AWS":"*"},"Action":"sqs:SendMessage","Resource":"arn:aws:sqs:eu-west-1:000000000000:some-queue","Condition":{"ArnLike":{"aws:SourceArn":"someservice-"}}}]}"`,
         )
       })
@@ -484,7 +484,7 @@ describe('SnsSqsPermissionConsumer', () => {
           newConsumer.subscriptionProps.queueUrl,
         )
 
-        expect(attributes.result?.attributes!.KmsMasterKeyId).toBe('othervalue')
+        expect(attributes.result?.attributes?.KmsMasterKeyId).toBe('othervalue')
       })
     })
 
diff --git a/packages/sns/test/publishers/SnsPermissionPublisher.payloadOffloading.spec.ts b/packages/sns/test/publishers/SnsPermissionPublisher.payloadOffloading.spec.ts
@@ -87,7 +87,7 @@ describe('SnsPermissionPublisher', () => {
         queueUrl,
         handleMessage: (message: Message) => {
           if (message !== null) receivedSnsMessages.push(message)
-          return Promise.resolve()
+          return Promise.resolve(message)
         },
         sqs: sqsClient,
         messageAttributeNames: [OFFLOADED_PAYLOAD_SIZE_ATTRIBUTE],
diff --git a/packages/sns/test/publishers/SnsPermissionPublisher.spec.ts b/packages/sns/test/publishers/SnsPermissionPublisher.spec.ts
@@ -242,7 +242,7 @@ describe('SnsPermissionPublisher', () => {
             )
             receivedMessage = decodedMessage.result!
           }
-          return Promise.resolve()
+          return Promise.resolve(message)
         },
         sqs: diContainer.cradle.sqsClient,
       })
@@ -305,7 +305,7 @@ describe('SnsPermissionPublisher', () => {
             )
             receivedMessage = decodedMessage.result!
           }
-          return Promise.resolve()
+          return Promise.resolve(message)
         },
         sqs: diContainer.cradle.sqsClient,
       })
diff --git a/packages/sqs/lib/utils/sqsAttributeUtils.ts b/packages/sqs/lib/utils/sqsAttributeUtils.ts
@@ -3,7 +3,7 @@ import {
   SQS_RESOURCE_ANY,
   SQS_RESOURCE_CURRENT_QUEUE,
   type SQSPolicyConfig,
-} from '../sqs/AbstractSqsService.js'
+} from '../sqs/AbstractSqsService.ts'
 
 const POLICY_VERSION = '2012-10-17'
 
diff --git a/packages/sqs/package.json b/packages/sqs/package.json
@@ -39,7 +39,7 @@
     "devDependencies": {
         "@aws-sdk/client-s3": "^3.812.0",
         "@aws-sdk/client-sqs": "^3.812.0",
-        "@biomejs/biome": "^2.2.0",
+        "@biomejs/biome": "^2.3.2",
         "@lokalise/biome-config": "^3.1.0",
         "@lokalise/tsconfig": "^3.0.0",
         "@message-queue-toolkit/core": "*",
diff --git a/packages/sqs/test/consumers/SqsPermissionConsumer.spec.ts b/packages/sqs/test/consumers/SqsPermissionConsumer.spec.ts
@@ -17,7 +17,7 @@ import { FakeConsumerErrorResolver } from '../../lib/fakes/FakeConsumerErrorReso
 import {
   SQS_RESOURCE_CURRENT_QUEUE,
   type SQSPolicyConfig,
-} from '../../lib/sqs/AbstractSqsService.js'
+} from '../../lib/sqs/AbstractSqsService.ts'
 import { assertQueue, deleteQueue, getQueueAttributes } from '../../lib/utils/sqsUtils.ts'
 import { FakeLogger } from '../fakes/FakeLogger.ts'
 import { SqsPermissionPublisher } from '../publishers/SqsPermissionPublisher.ts'
@@ -165,7 +165,7 @@ describe('SqsPermissionConsumer', () => {
 
         const attributes = await getQueueAttributes(sqsClient, newConsumer.queueProps.url)
 
-        expect(attributes.result?.attributes!.KmsMasterKeyId).toBe('somevalue')
+        expect(attributes.result?.attributes?.KmsMasterKeyId).toBe('somevalue')
       })
     })
 
diff --git a/packages/sqs/test/consumers/SqsPermisssionConsumer.deadLetterQueue.spec.ts b/packages/sqs/test/consumers/SqsPermisssionConsumer.deadLetterQueue.spec.ts
@@ -182,7 +182,7 @@ describe('SqsPermissionConsumer - deadLetterQueue', () => {
 
         const attributes = await getQueueAttributes(sqsClient, consumer.dlqUrl)
 
-        expect(attributes.result?.attributes!.KmsMasterKeyId).toBe('new value')
+        expect(attributes.result?.attributes?.KmsMasterKeyId).toBe('new value')
       })
 
       it('updates existing dlq tags', async () => {
diff --git a/packages/sqs/test/publishers/SqsPermissionPublisher.spec.ts b/packages/sqs/test/publishers/SqsPermissionPublisher.spec.ts
@@ -8,7 +8,7 @@ import { FakeConsumerErrorResolver } from '../../lib/fakes/FakeConsumerErrorReso
 import {
   SQS_RESOURCE_CURRENT_QUEUE,
   type SQSPolicyConfig,
-} from '../../lib/sqs/AbstractSqsService.js'
+} from '../../lib/sqs/AbstractSqsService.ts'
 import type { SQSMessage } from '../../lib/types/MessageTypes.ts'
 import { deserializeSQSMessage } from '../../lib/utils/sqsMessageDeserializer.ts'
 import { assertQueue, deleteQueue, getQueueAttributes } from '../../lib/utils/sqsUtils.ts'
@@ -113,7 +113,7 @@ describe('SqsPermissionPublisher', () => {
 
         const attributes = await getQueueAttributes(sqsClient, newPublisher.queueProps.url)
 
-        expect(attributes.result?.attributes!.KmsMasterKeyId).toBe('othervalue')
+        expect(attributes.result?.attributes?.KmsMasterKeyId).toBe('othervalue')
       })
 
       it('does not update existing queue when attributes did not change', async () => {
@@ -152,7 +152,7 @@ describe('SqsPermissionPublisher', () => {
 
         const attributes = await getQueueAttributes(sqsClient, newPublisher.queueProps.url)
 
-        expect(attributes.result?.attributes!.KmsMasterKeyId).toBe('somevalue')
+        expect(attributes.result?.attributes?.KmsMasterKeyId).toBe('somevalue')
       })
     })
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,6 @@ export abstract class AbstractAmqpPublisher<`
`93`	`93`	`this.logMessage(resolvedLogMessage)`
`94`	`94`	`}`
`95`	`95`
`96`		`- // biome-ignore lint/style/noParameterAssign: it's ok`
`97`	`96`	`message = this.updateInternalProperties(message)`
`98`	`97`
`99`	`98`	`try {`