Add one more test I want to find a fix for

Author: GenieTim

lib/Common/HybridBinarizer.php

@@ -266,7 +266,7 @@ private static function thresholdBlock(
 		for ($y = 0, $offset = $yoffset * $stride + $xoffset; $y < self::$BLOCK_SIZE; $y++, $offset += $stride) {
 			for ($x = 0; $x < self::$BLOCK_SIZE; $x++) {
 				// Comparison needs to be <= so that black == 0 pixels are black even if the threshold is 0.
-				if (($luminances[$offset + $x] & 0xFF) <= $threshold) {
+				if (($luminances[(int)round($offset + $x)] & 0xFF) <= $threshold) {
 					$matrix->set($xoffset + $x, $yoffset + $y);
 				}
 			}

lib/Common/PerspectiveTransform.php

@@ -173,8 +173,11 @@ public function transformPoints(array &$points, &$yValues = 0): void
 			$x = $points[$i];
 			$y = $points[$i + 1];
 			$denominator = $a13 * $x + $a23 * $y + $a33;
-			$points[$i] = ($a11 * $x + $a21 * $y + $a31) / $denominator;
-			$points[$i + 1] = ($a12 * $x + $a22 * $y + $a32) / $denominator;
+			// TODO: think what we do if $denominator == 0 (division by zero)
+			if ($denominator != 0.0) {
+				$points[$i] = ($a11 * $x + $a21 * $y + $a31) / $denominator;
+				$points[$i + 1] = ($a12 * $x + $a22 * $y + $a32) / $denominator;
+			}
 		}
 	}
 

lib/IMagickLuminanceSource.php

@@ -98,7 +98,7 @@ public function _IMagickLuminanceSource(\Imagick $image, $width, $height): void
 
 		$image->setImageColorspace(\Imagick::COLORSPACE_GRAY);
 		// Check that we actually have enough space to do it
-		if ($width * $height * 16 * 3 > $this->kmgStringToBytes(ini_get('memory_limit'))) {
+		if (ini_get('memory_limit') != -1 && $width * $height * 16 * 3 > $this->kmgStringToBytes(ini_get('memory_limit'))) {
 			throw new \RuntimeException("PHP Memory Limit does not allow pixel export.");
 		}
 		$pixels = $image->exportImagePixels(1, 1, $width, $height, "RGB", \Imagick::PIXEL_CHAR);

lib/Qrcode/Detector/FinderPatternFinder.php

@@ -609,7 +609,7 @@ private function selectBestPatterns()
 		$startSize = count($this->possibleCenters);
 		if ($startSize < 3) {
 			// Couldn't find enough finder patterns
-			throw new NotFoundException();
+			throw new NotFoundException("Could not find 3 finder patterns");
 		}
 
 		// Filter outlier possibilities whose module size is too different

tests/QrReaderTest.php

@@ -11,7 +11,7 @@ class QrReaderTest extends TestCase
 	public function setUp(): void
 	{
 		error_reporting(E_ALL);
-		ini_set('memory_limit','2G');
+		ini_set('memory_limit', '2G');
 	}
 
 	public function testText1()
@@ -54,4 +54,15 @@ public function testText3()
 		$this->assertSame(null, $qrcode->getError());
 		$this->assertSame("https://www.gosuslugi.ru/covid-cert/verify/9770000014233333?lang=ru&ck=733a9d218d312fe134f1c2cc06e1a800", $qrcode->text());
 	}
+
+	public function testText4()
+	{
+		$image = __DIR__ . "/qrcodes/174419877-f6b5dae1-2251-4b67-95f1-5e1143e40fae.jpg";
+		$qrcode = new QrReader($image);
+		$qrcode->decode([
+			'NR_ALLOW_SKIP_ROWS' => 0
+		]);
+		$this->assertSame(null, $qrcode->getError());
+		$this->assertSame("some text", $qrcode->text());
+	}
 }