Search for all version occurences and replace in all build files (better multi-project support

Author: kevcodez

ReplaceVersion.js

@@ -3,51 +3,63 @@ module.exports = {
     const oldVersion = dependency.oldVersion
     const newVersion = dependency.version
 
-    let modifiedBody = body
+    const replaceActions = []
 
     const regexVersionVariable = new RegExp(dependency.group + ":" + dependency.name + ":\\${?(\\w+)}?", "ig")
 
     // 'de.kevcodez:pubg-api-wrapper:$myVar'
     // 'de.kevcodez:pubg-api-wrapper:${myVar}'
-    const versionWithVariableMatches = regexVersionVariable.exec(modifiedBody)
+    const versionWithVariableMatches = regexVersionVariable.exec(body)
     if (versionWithVariableMatches && versionWithVariableMatches.length === 2) {
       const variableName = versionWithVariableMatches[1]
 
       const regexVariableDefinition = new RegExp(`(${variableName}(\\s+)?=(\\s+)?('|")${oldVersion}('|"))`, "ig")
-      const regexVariableDefinitionMatches = regexVariableDefinition.exec(modifiedBody)
+      const regexVariableDefinitionMatches = regexVariableDefinition.exec(body)
 
       if (regexVariableDefinitionMatches && regexVariableDefinitionMatches.length) {
         regexVariableDefinitionMatches.filter(it => it.includes(dependency.oldVersion)).forEach(match => {
-          modifiedBody = modifiedBody.replace(match, match.replace(dependency.oldVersion, dependency.version))
+          replaceActions.push({
+            searchValue: match,
+            replaceValue: match.replace(dependency.oldVersion, dependency.version)
+          })
         })
       }
     }
 
     // compile 'de.kevcodez:pubg-api-wrapper:1.0.0'
     const regexVersionInline = new RegExp(`${dependency.group}:${dependency.name}:${dependency.oldVersion}`, "g")
-    if (regexVersionInline.exec(modifiedBody)) {
-      modifiedBody = modifiedBody.replace(regexVersionInline, `${dependency.group}:${dependency.name}:${dependency.version}`)
+    if (regexVersionInline.exec(body)) {
+      replaceActions.push({
+        searchValue: regexVersionInline,
+        replaceValue: `${dependency.group}:${dependency.name}:${dependency.version}`
+      })
     }
 
     // id 'com.github.ben-manes.versions' version "0.21.0"
     // id("com.github.ben-manes.versions") version "0.22.0"
     const regexPluginVersionWithPrefix = new RegExp(`${dependency.group}("|')\\)?(\\s+)?version(\\s+)?("|')${oldVersion}("|')`)
-    const regexVersionWithPrefixMatches = regexPluginVersionWithPrefix.exec(modifiedBody)
+    const regexVersionWithPrefixMatches = regexPluginVersionWithPrefix.exec(body)
     if (regexVersionWithPrefixMatches && regexVersionWithPrefixMatches.length) {
       regexVersionWithPrefixMatches.filter(it => it.includes(oldVersion)).forEach(match => {
-        modifiedBody = modifiedBody.replace(match, match.replace(oldVersion, newVersion))
+        replaceActions.push({
+          searchValue: match,
+          replaceValue: match.replace(oldVersion, newVersion)
+        })
       })
     }
 
     // compile group: 'de.kevcodez.pubg', name: 'pubg-api-wrapper', version: '0.8.1'
     const regexDependencyWithVersionPrefix = new RegExp(`${dependency.name}('|"),(\\s+)?version:(\\s+)('|")${dependency.oldVersion}('|")`)
-    const regexDependencyWithVersionPrefixMatches = regexDependencyWithVersionPrefix.exec(modifiedBody)
+    const regexDependencyWithVersionPrefixMatches = regexDependencyWithVersionPrefix.exec(body)
     if (regexDependencyWithVersionPrefixMatches && regexDependencyWithVersionPrefixMatches.length) {
       regexDependencyWithVersionPrefixMatches.filter(it => it.includes(oldVersion)).forEach(match => {
-        modifiedBody = modifiedBody.replace(match, match.replace(oldVersion, newVersion))
+        replaceActions.push({
+          searchValue: match,
+          replaceValue: match.replace(oldVersion, newVersion)
+        })
       })
     }
 
-    return modifiedBody
+    return replaceActions
   }
 }

index.js

@@ -16,9 +16,8 @@ function debugLog(message) {
 const prompts = require('prompts');
 const {
   existsSync,
-  readFile,
   readFileSync,
-  writeFile
+  writeFileSync
 } = require('fs');
 const {
   subDirectories
@@ -63,10 +62,15 @@ async function executeCommandAndWaitForExitCode(command, args) {
 
   const child = spawn(command, args);
   child.stdout.setEncoding('utf8');
-  child.stdout.on('data', function (data) {
+  child.stdout.on('data', (data) => {
     debugLog(data);
   })
 
+  child.stderr.setEncoding('utf8');
+  child.stderr.on('data', (data) => {
+    console.error(data);
+  })
+
   child.on('close', (code) => {
     commandExitCode = code
   })
@@ -147,25 +151,50 @@ async function executeCommandAndWaitForExitCode(command, args) {
     }
   }
 
+  const allReplacements = []
+  const buildFileContentMap = new Map()
+
+
   buildFiles.forEach(buildFile => {
     debugLog(`Reading Gradle build file ${buildFile}\n`)
 
-    readFile(buildFile, function (err, buf) {
-      let buildFileAsString = buf.toString()
+    const fileDataBuffer = readFileSync(buildFile)
 
-      response.upgrades.filter(it => it !== 'gradle').forEach(it => {
-        debugLog(`Replacing version\n${JSON.stringify(it)}\n`)
-        buildFileAsString = ReplaceVersion.replace(buildFileAsString, it)
-      })
+    let buildFileAsString = fileDataBuffer.toString()
 
-      debugLog(`Writing Gradle build file ${buildFile}\n`)
-      writeFile(buildFile, buildFileAsString, 'utf8', function (err) {
-        if (err) return console.log(`Unable to write gradle build file.\n${err}`.bgRed);
-      });
+    response.upgrades.filter(it => it !== 'gradle').forEach(dependency => {
+      debugLog(`Replacing version\n${JSON.stringify(dependency)}\n`)
+      const replaceVersionActions = ReplaceVersion.replace(buildFileAsString, dependency)
 
-    });
+      replaceVersionActions.forEach(action => {
+        if (!allReplacements.some(it => it.searchValue === action.searchValue && it.replaceValue === action.replaceValue)) {
+          allReplacements.push(action)
+
+          debugLog(`${action.searchValue} => ${action.replaceValue}`)
+        }
+      })
+    })
+
+    buildFileContentMap.set(buildFile, buildFileAsString)
   })
 
+  buildFileContentMap.forEach((content, buildFile) => {
+
+    let modifiedContent = content
+
+    allReplacements.forEach(replaceAction => {
+      modifiedContent = modifiedContent.replace(replaceAction.searchValue, replaceAction.replaceValue)
+    })
+
+    debugLog(`Writing Gradle build file: ${buildFile}\n`)
+    try {
+      writeFileSync(buildFile, modifiedContent, 'utf8');
+    } catch (err) {
+      console.log(`Unable to write gradle build file.\n${err}`.bgRed);
+      return
+    }
+
+  }, buildFileContentMap)
 
 })();