Only replace version once, do not fail on second replacement

Author: kevcodez

ReplaceVersion.js

@@ -16,9 +16,11 @@ module.exports = {
       const regexVariableDefinition = new RegExp(`(${variableName}(\\s+)?=(\\s+)?('|")${oldVersion}('|"))`, "ig")
       const regexVariableDefinitionMatches = regexVariableDefinition.exec(modifiedBody)
 
-      regexVariableDefinitionMatches.filter(it => it.includes(dependency.oldVersion)).forEach(match => {
-        modifiedBody = modifiedBody.replace(match, match.replace(dependency.oldVersion, dependency.version))
-      })
+      if (regexVariableDefinitionMatches && regexVariableDefinitionMatches.length) {
+        regexVariableDefinitionMatches.filter(it => it.includes(dependency.oldVersion)).forEach(match => {
+          modifiedBody = modifiedBody.replace(match, match.replace(dependency.oldVersion, dependency.version))
+        })
+      }
     }
 
     // compile 'de.kevcodez:pubg-api-wrapper:1.0.0'
@@ -30,16 +32,16 @@ module.exports = {
     // id 'com.github.ben-manes.versions' version "0.21.0"
     const regexPluginVersionWithPrefix = new RegExp(`${dependency.group}("|')(\\s+)?version(\\s+)?("|')${oldVersion}("|')`)
     const regexVersionWithPrefixMatches = regexPluginVersionWithPrefix.exec(modifiedBody)
-    if (regexVersionWithPrefixMatches) {
+    if (regexVersionWithPrefixMatches && regexVersionWithPrefixMatches.length) {
       regexVersionWithPrefixMatches.filter(it => it.includes(oldVersion)).forEach(match => {
         modifiedBody = modifiedBody.replace(match, match.replace(oldVersion, newVersion))
       })
     }
-    
+
     // compile group: 'de.kevcodez.pubg', name: 'pubg-api-wrapper', version: '0.8.1'
     const regexDependencyWithVersionPrefix = new RegExp(`${dependency.name}('|"),(\\s+)?version:(\\s+)('|")${dependency.oldVersion}('|")`)
     const regexDependencyWithVersionPrefixMatches = regexDependencyWithVersionPrefix.exec(modifiedBody)
-    if (regexDependencyWithVersionPrefixMatches) {
+    if (regexDependencyWithVersionPrefixMatches && regexDependencyWithVersionPrefixMatches.length) {
       regexDependencyWithVersionPrefixMatches.filter(it => it.includes(oldVersion)).forEach(match => {
         modifiedBody = modifiedBody.replace(match, match.replace(oldVersion, newVersion))
       })

__tests__/ReplaceVersion.test.js

@@ -36,7 +36,14 @@ test('Replace version with variable with parenthensis and double quotation marks
 
     expect(replacedVersion).toContain(`myVar = "1.0.0"`)
 })
+test('Replace leave variable if it is already updated', () => {
+    const replacedVersion = ReplaceVersion.replace(`
+        myVar = "1.0.0"
+        compile 'de.kevcodez:pubg-api-wrapper:\$\{myVar\}'
+`, dependency)
 
+    expect(replacedVersion).toContain(`myVar = "1.0.0"`)
+})
 test('Replace plugin version with single quotation marks', () => {
     const pluginDependency = {
         group: 'com.github.ben-manes.versions',