Point at the associated type's def span

estebank · estebank · commit b6f4b29c6df3 · 2018-11-22T14:14:27.000-08:00
diff --git a/src/librustc_typeck/astconv.rs b/src/librustc_typeck/astconv.rs
@@ -1053,6 +1053,10 @@ impl<'o, 'gcx: 'tcx, 'tcx> dyn AstConv<'gcx, 'tcx>+'o {
                     span,
                     format!("missing associated type `{}` value", assoc_item.ident),
                 );
+                err.span_label(
+                    tcx.def_span(item_def_id),
+                    format!("`{}` defined here", assoc_item.ident),
+                );
             }
             err.emit();
         }
diff --git a/src/test/ui/associated-type/associated-type-projection-from-multiple-supertraits.stderr b/src/test/ui/associated-type/associated-type-projection-from-multiple-supertraits.stderr
@@ -25,6 +25,9 @@ LL | fn dent_object<COLOR>(c: BoxCar<Color=COLOR>) {
 error[E0191]: the value of the associated type `Color` (from the trait `Vehicle`) must be specified
   --> $DIR/associated-type-projection-from-multiple-supertraits.rs:33:26
    |
+LL |     type Color;
+   |     ----------- `Color` defined here
+...
 LL | fn dent_object<COLOR>(c: BoxCar<Color=COLOR>) {
    |                          ^^^^^^^^^^^^^^^^^^^ missing associated type `Color` value
 
diff --git a/src/test/ui/associated-types/associated-types-incomplete-object.stderr b/src/test/ui/associated-types/associated-types-incomplete-object.stderr
@@ -1,18 +1,29 @@
 error[E0191]: the value of the associated type `B` (from the trait `Foo`) must be specified
   --> $DIR/associated-types-incomplete-object.rs:33:26
    |
+LL |     type B;
+   |     ------- `B` defined here
+...
 LL |     let b = &42isize as &Foo<A=usize>;
    |                          ^^^^^^^^^^^^ missing associated type `B` value
 
 error[E0191]: the value of the associated type `A` (from the trait `Foo`) must be specified
   --> $DIR/associated-types-incomplete-object.rs:36:26
    |
+LL |     type A;
+   |     ------- `A` defined here
+...
 LL |     let c = &42isize as &Foo<B=char>;
    |                          ^^^^^^^^^^^ missing associated type `A` value
 
 error[E0191]: the value of the associated types `A` (from the trait `Foo`), `B` (from the trait `Foo`) must be specified
   --> $DIR/associated-types-incomplete-object.rs:39:26
    |
+LL |     type A;
+   |     ------- `A` defined here
+LL |     type B;
+   |     ------- `B` defined here
+...
 LL |     let d = &42isize as &Foo;
    |                          ^^^
    |                          |
diff --git a/src/test/ui/error-codes/E0107-b.stderr b/src/test/ui/error-codes/E0107-b.stderr
@@ -9,6 +9,12 @@ LL |  pub struct Foo { i: Box<T<usize, usize, usize, usize, B=usize>> }
 error[E0191]: the value of the associated types `A` (from the trait `T`), `C` (from the trait `T`) must be specified
   --> $DIR/E0107-b.rs:6:26
    |
+LL |     type A;
+   |     ------- `A` defined here
+LL |     type B;
+LL |     type C;
+   |     ------- `C` defined here
+LL | }
 LL |  pub struct Foo { i: Box<T<usize, usize, usize, usize, B=usize>> }
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |                          |
diff --git a/src/test/ui/error-codes/E0191.stderr b/src/test/ui/error-codes/E0191.stderr
@@ -1,6 +1,9 @@
 error[E0191]: the value of the associated type `Bar` (from the trait `Trait`) must be specified
   --> $DIR/E0191.rs:15:12
    |
+LL |     type Bar;
+   |     --------- `Bar` defined here
+...
 LL | type Foo = Trait; //~ ERROR E0191
    |            ^^^^^ missing associated type `Bar` value
 
diff --git a/src/test/ui/error-codes/E0220.stderr b/src/test/ui/error-codes/E0220.stderr
@@ -7,6 +7,9 @@ LL | type Foo = Trait<F=i32>; //~ ERROR E0220
 error[E0191]: the value of the associated type `Bar` (from the trait `Trait`) must be specified
   --> $DIR/E0220.rs:15:12
    |
+LL |     type Bar;
+   |     --------- `Bar` defined here
+...
 LL | type Foo = Trait<F=i32>; //~ ERROR E0220
    |            ^^^^^^^^^^^^ missing associated type `Bar` value
 
diff --git a/src/test/ui/issues/issue-19482.stderr b/src/test/ui/issues/issue-19482.stderr
@@ -1,6 +1,9 @@
 error[E0191]: the value of the associated type `A` (from the trait `Foo`) must be specified
   --> $DIR/issue-19482.rs:20:12
    |
+LL |     type A;
+   |     ------- `A` defined here
+...
 LL | fn bar(x: &Foo) {}
    |            ^^^ missing associated type `A` value
 
diff --git a/src/test/ui/issues/issue-21950.stderr b/src/test/ui/issues/issue-21950.stderr
@@ -11,6 +11,11 @@ error[E0191]: the value of the associated type `Output` (from the trait `std::op
    |
 LL |             &Add;
    |              ^^^ missing associated type `Output` value
+   | 
+  ::: $SRC_DIR/libcore/ops/arith.rs:LL:COL
+   |
+LL |     type Output;
+   |     ------------ `Output` defined here
 
 error: aborting due to 2 previous errors
 
diff --git a/src/test/ui/issues/issue-22434.stderr b/src/test/ui/issues/issue-22434.stderr
@@ -1,6 +1,9 @@
 error[E0191]: the value of the associated type `A` (from the trait `Foo`) must be specified
   --> $DIR/issue-22434.rs:15:19
    |
+LL |     type A;
+   |     ------- `A` defined here
+...
 LL | type I<'a> = &'a (Foo + 'a);
    |                   ^^^^^^^^ missing associated type `A` value
 
diff --git a/src/test/ui/issues/issue-22560.stderr b/src/test/ui/issues/issue-22560.stderr
@@ -29,6 +29,11 @@ LL | |             //~^ ERROR E0393
 LL | |             //~| ERROR E0191
 LL | |             Sub;
    | |_______________^ missing associated type `Output` value
+   | 
+  ::: $SRC_DIR/libcore/ops/arith.rs:LL:COL
+   |
+LL |       type Output;
+   |       ------------ `Output` defined here
 
 error: aborting due to 4 previous errors
 
diff --git a/src/test/ui/issues/issue-23024.stderr b/src/test/ui/issues/issue-23024.stderr
@@ -17,6 +17,11 @@ error[E0191]: the value of the associated type `Output` (from the trait `std::op
    |
 LL |     println!("{:?}",(vfnfer[0] as Fn)(3));
    |                                   ^^ missing associated type `Output` value
+   | 
+  ::: $SRC_DIR/libcore/ops/function.rs:LL:COL
+   |
+LL |     type Output;
+   |     ------------ `Output` defined here
 
 error: aborting due to 3 previous errors
 
diff --git a/src/test/ui/issues/issue-28344.stderr b/src/test/ui/issues/issue-28344.stderr
@@ -3,6 +3,11 @@ error[E0191]: the value of the associated type `Output` (from the trait `std::op
    |
 LL |     let x: u8 = BitXor::bitor(0 as u8, 0 as u8);
    |                 ^^^^^^^^^^^^^ missing associated type `Output` value
+   | 
+  ::: $SRC_DIR/libcore/ops/bit.rs:LL:COL
+   |
+LL |     type Output;
+   |     ------------ `Output` defined here
 
 error[E0599]: no function or associated item named `bitor` found for type `dyn std::ops::BitXor<_>` in the current scope
   --> $DIR/issue-28344.rs:14:17
@@ -17,6 +22,11 @@ error[E0191]: the value of the associated type `Output` (from the trait `std::op
    |
 LL |     let g = BitXor::bitor;
    |             ^^^^^^^^^^^^^ missing associated type `Output` value
+   | 
+  ::: $SRC_DIR/libcore/ops/bit.rs:LL:COL
+   |
+LL |     type Output;
+   |     ------------ `Output` defined here
 
 error[E0599]: no function or associated item named `bitor` found for type `dyn std::ops::BitXor<_>` in the current scope
   --> $DIR/issue-28344.rs:18:13
diff --git a/src/test/ui/traits/trait-alias-object.stderr b/src/test/ui/traits/trait-alias-object.stderr
@@ -11,6 +11,11 @@ error[E0191]: the value of the associated type `Item` (from the trait `std::iter
    |
 LL |     let _: &dyn IteratorAlias = &vec![123].into_iter();
    |             ^^^^^^^^^^^^^^^^^ missing associated type `Item` value
+   | 
+  ::: $SRC_DIR/libcore/iter/iterator.rs:LL:COL
+   |
+LL |     type Item;
+   |     ---------- `Item` defined here
 
 error: aborting due to 2 previous errors
 

Original file line number	Diff line number	Diff line change
`@@ -1053,6 +1053,10 @@ impl<'o, 'gcx: 'tcx, 'tcx> dyn AstConv<'gcx, 'tcx>+'o {`
`1053`	`1053`	`span,`
`1054`	`1054`	format!("missing associated type `{}` value", assoc_item.ident),
`1055`	`1055`	`);`
	`1056`	`+ err.span_label(`
	`1057`	`+ tcx.def_span(item_def_id),`
	`1058`	+ format!("`{}` defined here", assoc_item.ident),
	`1059`	`+ );`
`1056`	`1060`	`}`
`1057`	`1061`	`err.emit();`
`1058`	`1062`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,9 @@ LL \| fn dent_object<COLOR>(c: BoxCar<Color=COLOR>) {`
`25`	`25`	error[E0191]: the value of the associated type `Color` (from the trait `Vehicle`) must be specified
`26`	`26`	`--> $DIR/associated-type-projection-from-multiple-supertraits.rs:33:26`
`27`	`27`	`\|`
	`28`	`+LL \| type Color;`
	`29`	+ \| ----------- `Color` defined here
	`30`	`+...`
`28`	`31`	`LL \| fn dent_object<COLOR>(c: BoxCar<Color=COLOR>) {`
`29`	`32`	\| ^^^^^^^^^^^^^^^^^^^ missing associated type `Color` value
`30`	`33`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	error[E0191]: the value of the associated type `Bar` (from the trait `Trait`) must be specified
`2`	`2`	`--> $DIR/E0191.rs:15:12`
`3`	`3`	`\|`
	`4`	`+LL \| type Bar;`
	`5`	+ \| --------- `Bar` defined here
	`6`	`+...`
`4`	`7`	`LL \| type Foo = Trait; //~ ERROR E0191`
`5`	`8`	\| ^^^^^ missing associated type `Bar` value
`6`	`9`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@ LL \| type Foo = Trait<F=i32>; //~ ERROR E0220`
`7`	`7`	error[E0191]: the value of the associated type `Bar` (from the trait `Trait`) must be specified
`8`	`8`	`--> $DIR/E0220.rs:15:12`
`9`	`9`	`\|`
	`10`	`+LL \| type Bar;`
	`11`	+ \| --------- `Bar` defined here
	`12`	`+...`
`10`	`13`	`LL \| type Foo = Trait<F=i32>; //~ ERROR E0220`
`11`	`14`	\| ^^^^^^^^^^^^ missing associated type `Bar` value
`12`	`15`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	error[E0191]: the value of the associated type `A` (from the trait `Foo`) must be specified
`2`	`2`	`--> $DIR/issue-19482.rs:20:12`
`3`	`3`	`\|`
	`4`	`+LL \| type A;`
	`5`	+ \| ------- `A` defined here
	`6`	`+...`
`4`	`7`	`LL \| fn bar(x: &Foo) {}`
`5`	`8`	\| ^^^ missing associated type `A` value
`6`	`9`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	error[E0191]: the value of the associated type `A` (from the trait `Foo`) must be specified
`2`	`2`	`--> $DIR/issue-22434.rs:15:19`
`3`	`3`	`\|`
	`4`	`+LL \| type A;`
	`5`	+ \| ------- `A` defined here
	`6`	`+...`
`4`	`7`	`LL \| type I<'a> = &'a (Foo + 'a);`
`5`	`8`	\| ^^^^^^^^ missing associated type `A` value
`6`	`9`