Replace Project::getIdByName() with listNames()

Author: Art4

src/Redmine/Api/Issue.php

@@ -348,7 +348,12 @@ private function cleanParams(array $params = [])
         if (isset($params['project'])) {
             $projectApi = $this->getProjectApi();
 
-            $params['project_id'] = $projectApi->getIdByName($params['project']);
+            // TODO: project names are not unique; there could be collisions
+            $params['project_id'] = array_search(
+                $params['project'],
+                $projectApi->listNames(),
+                true,
+            );
             unset($params['project']);
         }
 

tests/Unit/Api/Issue/CreateTest.php

@@ -299,7 +299,7 @@ public function testCreateWithHttpClientRetrievesProjectId()
             $this,
             [
                 'GET',
-                '/projects.json',
+                '/projects.json?limit=100&offset=0',
                 'application/json',
                 '',
                 200,
@@ -450,7 +450,7 @@ public function testCreateWithClientCleansParameters()
             $this,
             [
                 'GET',
-                '/projects.json',
+                '/projects.json?limit=100&offset=0',
                 'application/json',
                 '',
                 200,

tests/Unit/Api/Issue/UpdateTest.php

@@ -119,7 +119,7 @@ public function testUpdateCleansParameters()
             $this,
             [
                 'GET',
-                '/projects.json',
+                '/projects.json?limit=100&offset=0',
                 'application/json',
                 '',
                 200,

tests/Unit/Api/IssueTest.php

@@ -8,6 +8,7 @@
 use Redmine\Api\Issue;
 use Redmine\Api\IssueCategory;
 use Redmine\Api\IssueStatus;
+use Redmine\Api\Project;
 use Redmine\Client\Client;
 use Redmine\Http\HttpClient;
 use Redmine\Http\Response;
@@ -146,7 +147,7 @@ public function testCreateWithClientCleansParameters()
         // Test values
         $response = '<?xml version="1.0"?><issue></issue>';
         $parameters = [
-            'project' => 'Project Name',
+            'project' => 'Project 1 Name',
             'category' => 'Category 5 Name',
             'status' => 'Status 6 Name',
             'tracker' => 'Tracker Name',
@@ -155,10 +156,6 @@ public function testCreateWithClientCleansParameters()
         ];
 
         // Create the used mock objects
-        $projectApi = $this->createMock('Redmine\Api\Project');
-        $projectApi->expects($this->exactly(1))
-            ->method('getIdByName')
-            ->willReturn(1);
         $getIdByNameApi = $this->createMock('Redmine\Api\Tracker');
         $getIdByNameApi->expects($this->exactly(1))
             ->method('getIdByName')
@@ -170,6 +167,15 @@ public function testCreateWithClientCleansParameters()
 
         $httpClient = AssertingHttpClient::create(
             $this,
+            [
+                'GET',
+                '/projects.json?limit=100&offset=0',
+                'application/json',
+                '',
+                200,
+                'application/json',
+                '{"projects":[{"id":1,"name":"Project 1 Name"},{"id":2,"name":"Project 1 Name"}]}',
+            ],
             [
                 'GET',
                 '/projects/1/issue_categories.json',
@@ -195,7 +201,7 @@ public function testCreateWithClientCleansParameters()
             ->method('getApi')
             ->willReturnMap(
                 [
-                    ['project', $projectApi],
+                    ['project', new Project($httpClient)],
                     ['issue_category', new IssueCategory($httpClient)],
                     ['issue_status', new IssueStatus($httpClient)],
                     ['tracker', $getIdByNameApi],