Extract User::listing()

Author: Art4

src/Redmine/Api/User.php

@@ -130,17 +130,7 @@ public function listing($forceUpdate = false, array $params = [])
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . __CLASS__ . '::listLogins()` instead.', E_USER_DEPRECATED);
 
-        if (empty($this->users) || $forceUpdate) {
-            $this->users = $this->list($params);
-        }
-        $ret = [];
-        if (is_array($this->users) && isset($this->users['users'])) {
-            foreach ($this->users['users'] as $e) {
-                $ret[$e['login']] = (int) $e['id'];
-            }
-        }
-
-        return $ret;
+        return $this->doListing($forceUpdate, $params);
     }
 
     /**
@@ -167,7 +157,8 @@ public function getCurrentUser(array $params = [])
      */
     public function getIdByUsername($username, array $params = [])
     {
-        $arr = $this->listing(false, $params);
+        $arr = $this->doListing(false, $params);
+
         if (!isset($arr[$username])) {
             return false;
         }
@@ -318,4 +309,21 @@ public function remove($id)
 
         return $this->lastResponse->getContent();
     }
+
+    private function doListing(bool $forceUpdate, array $params)
+    {
+        if (empty($this->users) || $forceUpdate) {
+            $this->users = $this->list($params);
+        }
+
+        $ret = [];
+
+        if (is_array($this->users) && isset($this->users['users'])) {
+            foreach ($this->users['users'] as $e) {
+                $ret[$e['login']] = (int) $e['id'];
+            }
+        }
+
+        return $ret;
+    }
 }