Skip to content

Omit falsy attributes from link(). #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kmonahan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Omit falsy attributes from link(). #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f142eaf
Omit falsy attributes from link().
kmonahan Nov 7, 2022
d241065
Omit the _keys array as well
kmonahan Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = function (title, url, attributes) {

// Loop through all the given attributes.
for (let attribute in attributes) {
if (Object.prototype.hasOwnProperty.call(attributes, attribute)) {
if (Object.prototype.hasOwnProperty.call(attributes, attribute) && attributes[attribute] && attribute !== '_keys') {
// Support arrays in the attributes list (e.g., class), or the object's toString().
finalAttributes += ' ' + attribute + '="' + (Array.isArray(attributes[attribute]) ? attributes[attribute].join(' ') : attributes[attribute]) + '"'
}
Expand Down