Skip to content

feat: implement robust plugin hook execution pipeline #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: implement robust plugin hook execution pipeline #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
249 changes: 249 additions & 0 deletions bin/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,255 @@ program
process.exit(1);
}
});

// Plugin management commands
const pluginCmd = program
.command('plugin')
.description('Manage plugins');

pluginCmd
.command('list')
.description('List all plugins in the current workspace')
.option('--json', 'Output as JSON')
.option('--enabled-only', 'Show only enabled plugins')
.action(async (opts) => {
try {
const { pluginSystem } = await import('./lib/plugin-system.js');
const cwd = process.cwd();

await pluginSystem.initialize(cwd);
const plugins = pluginSystem.getAllPlugins();

let filteredPlugins = plugins;
if (opts.enabledOnly) {
filteredPlugins = plugins.filter(p => p.enabled);
}

if (opts.json) {
console.log(JSON.stringify(filteredPlugins, null, 2));
} else {
if (filteredPlugins.length === 0) {
console.log(chalk.yellow('No plugins found.'));
return;
}

console.log(chalk.blue(`\n📦 Found ${filteredPlugins.length} plugin(s):\n`));
for (const plugin of filteredPlugins) {
const status = plugin.enabled ? chalk.green('enabled') : chalk.red('disabled');
const type = plugin.type === 'local' ? chalk.cyan('local') : chalk.magenta('external');
console.log(` ${chalk.bold(plugin.name)} [${status}] (${type})`);
if (plugin.plugin?.description) {
console.log(` ${chalk.gray(plugin.plugin.description)}`);
}
if (plugin.plugin?.version) {
console.log(` ${chalk.gray('v' + plugin.plugin.version)}`);
}
console.log();
}
}
} catch (e) {
console.error(chalk.red('Failed to list plugins:'), e.message);
process.exit(1);
}
});

pluginCmd
.command('enable')
.description('Enable a plugin')
.argument('<name>', 'Plugin name')
.action(async (name) => {
try {
const { pluginSystem } = await import('./lib/plugin-system.js');
const cwd = process.cwd();

await pluginSystem.initialize(cwd);
await pluginSystem.enablePlugin(name);

console.log(chalk.green(`✅ Plugin '${name}' enabled successfully`));
} catch (e) {
console.error(chalk.red('Failed to enable plugin:'), e.message);
process.exit(1);
}
});

pluginCmd
.command('disable')
.description('Disable a plugin')
.argument('<name>', 'Plugin name')
.action(async (name) => {
try {
const { pluginSystem } = await import('./lib/plugin-system.js');
const cwd = process.cwd();

await pluginSystem.initialize(cwd);
await pluginSystem.disablePlugin(name);

console.log(chalk.green(`✅ Plugin '${name}' disabled successfully`));
} catch (e) {
console.error(chalk.red('Failed to disable plugin:'), e.message);
process.exit(1);
}
});

pluginCmd
.command('info')
.description('Show detailed information about a plugin')
.argument('<name>', 'Plugin name')
.option('--json', 'Output as JSON')
.action(async (name, opts) => {
try {
const { pluginSystem, HOOK_POINTS } = await import('./lib/plugin-system.js');
const cwd = process.cwd();

await pluginSystem.initialize(cwd);
const plugin = pluginSystem.getPlugin(name);

if (!plugin) {
console.log(chalk.yellow(`Plugin '${name}' not found.`));
process.exit(1);
}

if (opts.json) {
const info = {
name: plugin.name,
type: plugin.type,
enabled: plugin.enabled,
loadedAt: plugin.loadedAt,
plugin: plugin.plugin,
config: plugin.config
};
console.log(JSON.stringify(info, null, 2));
} else {
console.log(chalk.blue(`\n📦 Plugin: ${chalk.bold(plugin.name)}\n`));
console.log(`Type: ${plugin.type === 'local' ? chalk.cyan('Local') : chalk.magenta('External')}`);
console.log(`Status: ${plugin.enabled ? chalk.green('Enabled') : chalk.red('Disabled')}`);
console.log(`Loaded: ${plugin.loadedAt ? new Date(plugin.loadedAt).toLocaleString() : 'Not loaded'}`);

if (plugin.plugin) {
if (plugin.plugin.version) {
console.log(`Version: ${plugin.plugin.version}`);
}
if (plugin.plugin.description) {
console.log(`Description: ${plugin.plugin.description}`);
}

if (plugin.plugin.hooks) {
console.log(`\nHooks (${Object.keys(plugin.plugin.hooks).length}):`);
for (const [hookName, handler] of Object.entries(plugin.plugin.hooks)) {
const description = HOOK_POINTS[hookName] || 'Custom hook';
console.log(` ${chalk.cyan(hookName)} - ${chalk.gray(description)}`);
}
}

if (plugin.plugin.methods) {
console.log(`\nMethods (${Object.keys(plugin.plugin.methods).length}):`);
for (const methodName of Object.keys(plugin.plugin.methods)) {
console.log(` ${chalk.cyan(methodName)}`);
}
}
}

if (plugin.config) {
console.log(`\nConfiguration:`);
console.log(JSON.stringify(plugin.config, null, 2));
}
console.log();
}
} catch (e) {
console.error(chalk.red('Failed to get plugin info:'), e.message);
process.exit(1);
}
});

pluginCmd
.command('configure')
.description('Configure a plugin')
.argument('<name>', 'Plugin name')
.option('--config <json>', 'Configuration as JSON string')
.option('--priority <number>', 'Plugin loading priority (higher = loads first)')
.option('--external <path>', 'Set external plugin path or npm package')
.action(async (name, opts) => {
try {
const { pluginSystem } = await import('./lib/plugin-system.js');
const cwd = process.cwd();

await pluginSystem.initialize(cwd);

const config = {};

if (opts.config) {
try {
Object.assign(config, JSON.parse(opts.config));
} catch (e) {
console.error(chalk.red('Invalid JSON in --config option'));
process.exit(1);
}
}

if (opts.priority !== undefined) {
config.priority = parseInt(opts.priority);
}

if (opts.external) {
config.external = opts.external;
}

if (Object.keys(config).length === 0) {
console.log(chalk.yellow('No configuration options provided. Use --config, --priority, or --external.'));
process.exit(1);
}

await pluginSystem.configurePlugin(name, config);

console.log(chalk.green(`✅ Plugin '${name}' configured successfully`));
console.log('New configuration:', JSON.stringify(config, null, 2));
} catch (e) {
console.error(chalk.red('Failed to configure plugin:'), e.message);
process.exit(1);
}
});

pluginCmd
.command('stats')
.description('Show plugin system statistics')
.option('--json', 'Output as JSON')
.action(async (opts) => {
try {
const { pluginSystem } = await import('./lib/plugin-system.js');
const cwd = process.cwd();

await pluginSystem.initialize(cwd);
const stats = pluginSystem.getStats();

if (opts.json) {
console.log(JSON.stringify(stats, null, 2));
} else {
console.log(chalk.blue('\n📊 Plugin System Statistics\n'));
console.log(`Initialized: ${stats.initialized ? chalk.green('Yes') : chalk.red('No')}`);
console.log(`Project Directory: ${stats.projectDir || 'N/A'}`);
console.log(`Total Plugins: ${stats.totalPlugins}`);
console.log(`Enabled Plugins: ${stats.enabledPlugins}`);
console.log(`Available Hook Points: ${stats.hookPoints}`);

console.log('\nRegistered Hooks:');
for (const [hookName, count] of Object.entries(stats.registeredHooks)) {
console.log(` ${chalk.cyan(hookName)}: ${count} handler(s)`);
}

if (Object.keys(stats.config).length > 0) {
console.log('\nPlugin Configuration:');
for (const [pluginName, config] of Object.entries(stats.config)) {
console.log(` ${chalk.bold(pluginName)}:`);
console.log(` ${JSON.stringify(config, null, 4).replace(/^/gm, ' ')}`);
}
}
console.log();
}
} catch (e) {
console.error(chalk.red('Failed to get plugin stats:'), e.message);
process.exit(1);
}
});

program.parse();

Expand Down
21 changes: 20 additions & 1 deletion bin/lib/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { spawn } from 'node:child_process';
import { WebSocketServer, WebSocket } from 'ws';
import { getLogsForAPI, LogFileWatcher } from './logs.js';
import { startService, stopService, restartService, getServiceStatus, getAllServiceStatuses, validateServiceCanRun } from './service-manager.js';
import { initializePlugins, callHook } from './plugin-system.js';

// ws helper
function sendWebSocketMessage(ws, message) {
Expand Down Expand Up @@ -886,6 +887,15 @@ export async function startAdminDashboard(options = {}) {
process.exit(1);
}

// Initialize plugins
await initializePlugins(cwd);

// Call before:admin:start hook
await callHook('before:admin:start', {
projectDir: cwd,
options
});

const cfg = JSON.parse(fs.readFileSync(configPath, 'utf-8'));
const port = options.port || 8080;
const refreshInterval = options.refresh || 5000;
Expand Down Expand Up @@ -1064,9 +1074,18 @@ export async function startAdminDashboard(options = {}) {
res.end(html);
});

server.listen(port, () => {
server.listen(port, async () => {
console.log(chalk.green(`✅ Admin Dashboard running at http://localhost:${port}`));

// Call after:admin:start hook
await callHook('after:admin:start', {
projectDir: cwd,
port,
dashboardUrl: `http://localhost:${port}`,
options,
services: cfg.services
});

// Auto-open browser if requested
if (options.open !== false) {
const url = `http://localhost:${port}`;
Expand Down
36 changes: 35 additions & 1 deletion bin/lib/dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import chalk from 'chalk';
import { spawn } from 'node:child_process';
import http from 'http';
import { initializeServiceLogs } from './logs.js';
import { initializePlugins, callHook } from './plugin-system.js';
import { fileURLToPath } from 'url';

const __filename = fileURLToPath(import.meta.url);
Expand Down Expand Up @@ -70,6 +71,17 @@ export async function runDev({ docker=false } = {}) {
console.error(chalk.red('polyglot.json not found. Run inside a generated workspace.'));
process.exit(1);
}

// Initialize plugins
await initializePlugins(cwd);

// Call before:dev:start hook
await callHook('before:dev:start', {
projectDir: cwd,
docker,
mode: docker ? 'docker' : 'local'
});

const cfg = JSON.parse(fs.readFileSync(configPath, 'utf-8'));
const servicesDir = path.join(cwd, 'services');
if (!fs.existsSync(servicesDir)) {
Expand Down Expand Up @@ -164,9 +176,31 @@ const args = ['run', useScript];
}
await Promise.all(healthPromises);

// Call after:dev:start hook
await callHook('after:dev:start', {
projectDir: cwd,
docker,
mode: docker ? 'docker' : 'local',
processes: procs.length,
services: procs.map(p => p.serviceName).filter(Boolean)
});

if (procs.length > 0) {
console.log(chalk.blue('Watching services. Press Ctrl+C to exit.'));
process.on('SIGINT', () => { procs.forEach(p => p.kill('SIGINT')); process.exit(0); });
process.on('SIGINT', async () => {
await callHook('before:dev:stop', {
projectDir: cwd,
docker,
mode: docker ? 'docker' : 'local'
});
procs.forEach(p => p.kill('SIGINT'));
await callHook('after:dev:stop', {
projectDir: cwd,
docker,
mode: docker ? 'docker' : 'local'
});
process.exit(0);
});
}
}

Expand Down
Loading
Loading