-
-
Notifications
You must be signed in to change notification settings - Fork 210
FE: Add whitespace after readonly cluster name tag #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi trvrnrth! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
653f554 to
6feb22a
Compare
Haarolean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done with CSS
|
@trvrnrth thanks! |
What changes did you make? (Give an overview)
Add whitespace after the readonly tag next to the cluster name in the dashboard. Follows the approach taken for the internal tag on topics:
kafka-ui/frontend/src/components/Topics/List/TopicTitleCell.tsx
Line 20 in 3c1fd1f
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Before:

After:

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)