Skip to content

Commit c23ceba

Browse files
committed
fix duplicate value assigning to log
1 parent f4fe04d commit c23ceba

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

cloud/scheduler/scheduler.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,24 +42,23 @@ func NewManager(params SchedulerParams) *Manager {
4242

4343
// return new/existing scheduler
4444
func (m *Manager) GetOrCreateScheduler(client *proxmox.Service) *Scheduler {
45-
m.params.Logger = m.params.Logger.WithValues("Name", "qemu-scheduler")
4645
schedID, err := m.getSchedulerID(client)
4746
if err != nil {
4847
// create new scheduler without registering
4948
// to not make it zombie scheduler set timeout to context
5049
sched := m.NewScheduler(client, WithTimeout(1*time.Minute))
5150
return sched
5251
}
53-
m.params.Logger = m.params.Logger.WithValues("scheduler ID", *schedID)
5452
sched, ok := m.table[*schedID]
5553
if !ok {
5654
// create and register new scheduler
5755
m.params.Logger.V(5).Info("registering new scheduler")
5856
sched := m.NewScheduler(client)
57+
sched.logger = sched.logger.WithValues("scheduler ID", *schedID)
5958
m.table[*schedID] = sched
6059
return sched
6160
}
62-
m.params.Logger.V(5).Info("using existing scheduler")
61+
sched.logger.V(5).Info("using existing scheduler")
6362
return sched
6463
}
6564

@@ -76,7 +75,7 @@ func (m *Manager) NewScheduler(client *proxmox.Service, opts ...SchedulerOption)
7675
vmidPlugins: plugins.NewVMIDPlugins(),
7776

7877
resultMap: make(map[string]chan *framework.CycleState),
79-
logger: m.params.Logger,
78+
logger: m.params.Logger.WithValues("Name", "qemu-scheduler"),
8079

8180
ctx: ctx,
8281
cancel: cancel,

0 commit comments

Comments
 (0)