vmid should be patched only after vm creation is successful

Author: sp-yduck

cloud/services/compute/instance/qemu.go

@@ -17,6 +17,7 @@ const (
 	bootDvice = "scsi0"
 )
 
+// reconciles QEMU instance
 func (s *Service) reconcileQEMU(ctx context.Context) (*proxmox.VirtualMachine, error) {
 	log := log.FromContext(ctx)
 	log.Info("Reconciling QEMU")
@@ -67,10 +68,6 @@ func (s *Service) createQEMU(ctx context.Context, nodeName string, vmid *int) (*
 			return nil, err
 		}
 		vmid = &nextid
-		s.scope.SetVMID(*vmid)
-		if err := s.scope.PatchObject(); err != nil {
-			return nil, err
-		}
 	}
 
 	vmoption := s.generateVMOptions()
@@ -79,6 +76,10 @@ func (s *Service) createQEMU(ctx context.Context, nodeName string, vmid *int) (*
 		log.Error(err, fmt.Sprintf("failed to create qemu instance %s", vm.VM.Name))
 		return nil, err
 	}
+	s.scope.SetVMID(*vmid)
+	if err := s.scope.PatchObject(); err != nil {
+		return nil, err
+	}
 	return vm, nil
 }
 

cloud/services/compute/instance/reconcile.go

@@ -133,6 +133,7 @@ func getBiosUUIDFromVM(ctx context.Context, vm *proxmox.VirtualMachine) (*string
 	return pointer.String(uuid), nil
 }
 
+// reconciles qemu, cloud-config, os image and storage
 func (s *Service) createInstance(ctx context.Context) (*proxmox.VirtualMachine, error) {
 	log := log.FromContext(ctx)