enable vm level firewall by default

Author: sp-yduck

api/v1beta1/proxmoxmachine_types.go

@@ -53,7 +53,7 @@ type ProxmoxMachineSpec struct {
 	CloudInit CloudInit `json:"cloudInit,omitempty"`
 
 	// Hardware
-	// +kubebuilder:default:={cpu:2,disk:"50G",memory:4096,networkDevice:{model:virtio,bridge:vmbr0}}
+	// +kubebuilder:default:={cpu:2,disk:"50G",memory:4096,networkDevice:{model:virtio,bridge:vmbr0,firewall:true}}
 	Hardware Hardware `json:"hardware"`
 
 	// Network

api/v1beta1/type.go

@@ -98,7 +98,7 @@ type Hardware struct {
 
 	// network devices
 	// to do: multiple devices
-	// +kubebuilder:default:={model:virtio,bridge:vmbr0}
+	// +kubebuilder:default:={model:virtio,bridge:vmbr0,firewall:true}
 	NetworkDevice NetworkDevice `json:"networkDevice"`
 }
 
@@ -110,6 +110,7 @@ type NetworkDevice struct {
 	// +kubebuilder:default:="vmbr0"
 	Bridge NetworkDeviceBridge `json:"bridge"`
 
+	// +kubebuilder:default:=true
 	Firewall bool `json:"firewall,omitempty"`
 
 	LinkDown bool `json:"linkDown,omitempty"`

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachines.yaml

@@ -225,6 +225,7 @@ spec:
                   memory: 4096
                   networkDevice:
                     bridge: vmbr0
+                    firewall: true
                     model: virtio
                 description: Hardware
                 properties:
@@ -258,6 +259,7 @@ spec:
                   networkDevice:
                     default:
                       bridge: vmbr0
+                      firewall: true
                       model: virtio
                     description: 'network devices to do: multiple devices'
                     properties:
@@ -266,6 +268,7 @@ spec:
                         pattern: vmbr[0-9]{1,4}
                         type: string
                       firewall:
+                        default: true
                         type: boolean
                       linkDown:
                         type: boolean

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachinetemplates.yaml

@@ -242,6 +242,7 @@ spec:
                           memory: 4096
                           networkDevice:
                             bridge: vmbr0
+                            firewall: true
                             model: virtio
                         description: Hardware
                         properties:
@@ -275,6 +276,7 @@ spec:
                           networkDevice:
                             default:
                               bridge: vmbr0
+                              firewall: true
                               model: virtio
                             description: 'network devices to do: multiple devices'
                             properties:
@@ -283,6 +285,7 @@ spec:
                                 pattern: vmbr[0-9]{1,4}
                                 type: string
                               firewall:
+                                default: true
                                 type: boolean
                               linkDown:
                                 type: boolean