stop creating qemu if there is already same name qemu

Author: sp-yduck

cloud/services/compute/instance/qemu.go

@@ -21,16 +21,35 @@ func (s *Service) reconcileQEMU(ctx context.Context) (*proxmox.VirtualMachine, e
 	log.Info("Reconciling QEMU")
 
 	qemu, err := s.getQEMU(ctx)
-	if err == nil { // if qemu is found, return it
-		return qemu, nil
+	if err != nil {
+		if !rest.IsNotFound(err) {
+			log.Error(err, "failed to get qemu")
+			return nil, err
+		}
+
+		// no qemu found, try to create new one
+		log.V(3).Info("qemu wasn't found. new qemu will be created")
+		if exist, err := s.client.VirtualMachineExistsWithName(ctx, s.scope.Name()); exist || err != nil {
+			if exist {
+				// there should no qemu with same name. occuring an error
+				err = fmt.Errorf("qemu %s already exists", s.scope.Name())
+			}
+			log.Error(err, "stop creating new qemu to avoid replicating same qemu")
+			return nil, err
+		}
+		qemu, err = s.createQEMU(ctx)
+		if err != nil {
+			log.Error(err, "failed to create qemu")
+			return nil, err
+		}
 	}
-	if !rest.IsNotFound(err) {
-		log.Error(err, "failed to get qemu")
+
+	s.scope.SetVMID(qemu.VM.VMID)
+	s.scope.SetNodeName(qemu.Node)
+	if err := s.scope.PatchObject(); err != nil {
 		return nil, err
 	}
-
-	// no qemu found, create new one
-	return s.createQEMU(ctx)
+	return qemu, nil
 }
 
 // get QEMU gets proxmox vm from vmid
@@ -62,12 +81,6 @@ func (s *Service) createQEMU(ctx context.Context) (*proxmox.VirtualMachine, erro
 		log.Error(err, "failed to create qemu instance")
 		return nil, err
 	}
-
-	s.scope.SetNodeName(result.Node())
-	s.scope.SetVMID(result.VMID())
-	if err := s.scope.PatchObject(); err != nil {
-		return nil, err
-	}
 	return result.Instance(), nil
 }
 

go.mod

@@ -8,7 +8,7 @@ require (
 	github.com/onsi/ginkgo/v2 v2.13.1
 	github.com/onsi/gomega v1.30.0
 	github.com/pkg/errors v0.9.1
-	github.com/sp-yduck/proxmox-go v0.0.0-alpha23
+	github.com/sp-yduck/proxmox-go v0.0.0-alpha24
 	github.com/spf13/pflag v1.0.5
 	gopkg.in/yaml.v3 v3.0.1
 	k8s.io/api v0.27.2

go.sum

@@ -417,8 +417,8 @@ github.com/sirupsen/logrus v1.7.0/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic
 github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d/go.mod h1:OnSkiWE9lh6wB0YB77sQom3nweQdgAjqCqsofrRNTgc=
 github.com/smartystreets/goconvey v1.6.4/go.mod h1:syvi0/a8iFYH4r/RixwvyeAJjdLS9QV7WQ/tjFTllLA=
 github.com/soheilhy/cmux v0.1.4/go.mod h1:IM3LyeVVIOuxMH7sFAkER9+bJ4dT7Ms6E4xg4kGIyLM=
-github.com/sp-yduck/proxmox-go v0.0.0-alpha23 h1:dRewwKbfqiw8dVvbfjdSR0id7DzmlljnAqyGqqva2TM=
-github.com/sp-yduck/proxmox-go v0.0.0-alpha23/go.mod h1:iEI7ilRwyUaWvoxuXs/30UJ2f8Z2TWXCW1cZ3QeU2JY=
+github.com/sp-yduck/proxmox-go v0.0.0-alpha24 h1:c858F6hudBHXZgTFlgOu2VuqWOXsAbbxV2axZICmVQQ=
+github.com/sp-yduck/proxmox-go v0.0.0-alpha24/go.mod h1:iEI7ilRwyUaWvoxuXs/30UJ2f8Z2TWXCW1cZ3QeU2JY=
 github.com/spaolacci/murmur3 v0.0.0-20180118202830-f09979ecbc72/go.mod h1:JwIasOWyU6f++ZhiEuf87xNszmSA2myDM2Kzu9HwQUA=
 github.com/spf13/afero v1.1.2/go.mod h1:j4pytiNVoe2o6bmDsKpLACNPDBIoEAkihy7loJ1B0CQ=
 github.com/spf13/afero v1.9.5 h1:stMpOSZFs//0Lv29HduCmli3GUfpFoF3Y1Q/aXj/wVM=