Skip to content

Commit 0644e40

Browse files
committed
Fix problems with Qt4.
1 parent ac74dbd commit 0644e40

File tree

6 files changed

+11
-20
lines changed

6 files changed

+11
-20
lines changed

src/Editor.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include "MainWindow.hpp"
2121

2222
#include <QGraphicsItem>
23-
#include <QDebug>
2423

2524
#include <cassert>
2625

@@ -55,15 +54,13 @@ EditorScene & Editor::scene() const
5554

5655
void Editor::setImage(QImage image)
5756
{
57+
m_view->ensureVisible(0, 0, 0, 0);
58+
5859
m_pixmap.convertFromImage(image);
5960

60-
m_view->ensureVisible(0, 0, 0, 0);
6161
m_scene->setSceneRect(0, 0, m_pixmap.width(), m_pixmap.height());
6262
m_scene->clear();
63-
64-
QGraphicsItem * imageItem = new ImageItem(m_pixmap);
65-
m_scene->addItem(imageItem);
66-
imageItem->setPos(m_pixmap.width() / 2, m_pixmap.height() / 2);
63+
m_scene->addItem(new QGraphicsPixmapItem(m_pixmap));
6764

6865
// Renderer is a thread so use invokeMethod to safely set the input.
6966
QMetaObject::invokeMethod(m_renderer, "setInput", Q_ARG(QImage, image));

src/EditorView.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
#include "Editor.hpp"
1818
#include "EditorScene.hpp"
1919

20-
#include <QDebug>
21-
2220
EditorView::EditorView(Editor & editor, QWidget * parent)
2321
: QGraphicsView(&editor.scene(), parent)
2422
, m_editor(editor)

src/MainWindow.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
#include <QApplication>
2828
#include <QCloseEvent>
2929
#include <QDateTime>
30-
#include <QDebug>
3130
#include <QDesktopWidget>
3231
#include <QFileDialog>
3332
#include <QHBoxLayout>

src/RenderPreview.cpp

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
#include "RenderPreview.hpp"
1717
#include "Editor.hpp"
18+
#include "ImageItem.hpp"
1819
#include "Settings.hpp"
1920

2021
#include <QFileDialog>
@@ -37,13 +38,10 @@ RenderPreview::~RenderPreview()
3738
{
3839
}
3940

40-
void RenderPreview::prepareForImage(QImage image)
41+
void RenderPreview::prepareForImage(const QImage & image)
4142
{
42-
QPixmap pixmap;
43-
pixmap.convertFromImage(image);
44-
4543
m_scene.clear();
46-
m_scene.setSceneRect(0, 0, pixmap.width(), pixmap.height());
44+
m_scene.setSceneRect(0, 0, image.width(), image.height());
4745
}
4846

4947
void RenderPreview::render()
@@ -54,11 +52,11 @@ void RenderPreview::render()
5452

5553
void RenderPreview::updatePreview(const QImage & result)
5654
{
55+
QPixmap pixmap = QPixmap::fromImage(result);
56+
5757
m_scene.clear();
58-
QPixmap pixmap;
59-
pixmap.fromImage(result);
60-
QGraphicsPixmapItem* item = m_scene.addPixmap(pixmap);
61-
item->setPos(0, 0);
58+
m_scene.setSceneRect(0, 0, pixmap.width(), pixmap.height());
59+
m_scene.addItem(new QGraphicsPixmapItem(pixmap));
6260
}
6361

6462
void RenderPreview::save()

src/RenderPreview.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public slots:
3636

3737
void save();
3838

39-
void prepareForImage(QImage image);
39+
void prepareForImage(const QImage & image);
4040

4141
private slots:
4242

src/Renderer.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
#include "Renderer.hpp"
1717

18-
#include <QDebug>
1918
#include <QImage>
2019
#include <QRgb>
2120
#include <cmath>

0 commit comments

Comments
 (0)