Added host header to proxy connect request in order to be compliant with HTTP 1.1 (#877)

Rurido · RR55 · web-flow · commit 8ce56f76d915 · 2021-08-15T23:49:22.000-06:00
Co-authored-by: RR55 &lt;git@rurido.de&gt;
diff --git a/src/Titanium.Web.Proxy/Network/TcpConnection/TcpConnectionFactory.cs b/src/Titanium.Web.Proxy/Network/TcpConnection/TcpConnectionFactory.cs
@@ -520,15 +520,17 @@ internal Task<TcpServerConnection> GetServerConnection(ProxyServer proxyServer,
 
                 if (externalProxy != null && externalProxy.ProxyType == ExternalProxyType.Http && (isConnect || isHttps))
                 {
-                    var authority = $"{remoteHostName}:{remotePort}".GetByteString();
-                    var connectRequest = new ConnectRequest(authority)
+                    var authority = $"{remoteHostName}:{remotePort}";
+                    var authorityBytes = authority.GetByteString();
+                    var connectRequest = new ConnectRequest(authorityBytes)
                     {
                         IsHttps = isHttps,
-                        RequestUriString8 = authority,
+                        RequestUriString8 = authorityBytes,
                         HttpVersion = httpVersion
                     };
 
                     connectRequest.Headers.AddHeader(KnownHeaders.Connection, KnownHeaders.ConnectionKeepAlive);
+                    connectRequest.Headers.AddHeader(KnownHeaders.Host, authority);
 
                     if (!string.IsNullOrEmpty(externalProxy.UserName) && externalProxy.Password != null)
                     {

Original file line number	Diff line number	Diff line change
`@@ -520,15 +520,17 @@ internal Task<TcpServerConnection> GetServerConnection(ProxyServer proxyServer,`
`520`	`520`
`521`	`521`	`if (externalProxy != null && externalProxy.ProxyType == ExternalProxyType.Http && (isConnect \|\| isHttps))`
`522`	`522`	`{`
`523`		`- var authority = $"{remoteHostName}:{remotePort}".GetByteString();`
`524`		`- var connectRequest = new ConnectRequest(authority)`
	`523`	`+ var authority = $"{remoteHostName}:{remotePort}";`
	`524`	`+ var authorityBytes = authority.GetByteString();`
	`525`	`+ var connectRequest = new ConnectRequest(authorityBytes)`
`525`	`526`	`{`
`526`	`527`	`IsHttps = isHttps,`
`527`		`- RequestUriString8 = authority,`
	`528`	`+ RequestUriString8 = authorityBytes,`
`528`	`529`	`HttpVersion = httpVersion`
`529`	`530`	`};`
`530`	`531`
`531`	`532`	`connectRequest.Headers.AddHeader(KnownHeaders.Connection, KnownHeaders.ConnectionKeepAlive);`
	`533`	`+ connectRequest.Headers.AddHeader(KnownHeaders.Host, authority);`
`532`	`534`
`533`	`535`	`if (!string.IsNullOrEmpty(externalProxy.UserName) && externalProxy.Password != null)`
`534`	`536`	`{`