made changes requested by review

Author: telamonian

src/model.ts

@@ -89,7 +89,6 @@ export class GitExtension implements IGitExtension, IDisposable {
 
           if (change.newValue !== change.oldValue) {
             this.refresh().then(() => this._repositoryChanged.emit(change));
-            this._repositoryChanged.emit(change);
           }
         })
         .catch(reason => {
@@ -337,7 +336,7 @@ export class GitExtension implements IGitExtension, IDisposable {
   }
 
   /** Refresh the git repository status */
-  async _refreshStatus(): Promise<void> {
+  protected async _refreshStatus(): Promise<void> {
     await this.ready;
     const path = this.pathRepository;
 
@@ -422,7 +421,7 @@ export class GitExtension implements IGitExtension, IDisposable {
   }
 
   /** Make request for a list of all git branches in the repository */
-  async _branch(): Promise<Git.IBranchResult> {
+  protected async _branch(): Promise<Git.IBranchResult> {
     await this.ready;
     const path = this.pathRepository;
 

src/utils.ts

@@ -31,7 +31,7 @@ export function extractFilename(path: string): string {
   }
 }
 
-export function decodeStage(x: string, y: string) {
+export function decodeStage(x: string, y: string): string | null {
   // If file is untracked
   if (x === '?' && y === '?') {
     return 'untracked';
@@ -46,7 +46,7 @@ export function decodeStage(x: string, y: string) {
     }
   }
 
-  return undefined;
+  return null;
 }
 
 /** Open a file in the git listing */