refactor: list of git auth error messages

Author: ktaletsk

src/git.ts

@@ -192,6 +192,15 @@ export interface IGitPushPullResult {
   message?: string;
 }
 
+/**
+ * Array of Git Auth Error Messages
+ */
+export const AUTH_ERROR_MESSAGES = [
+  'Invalid username or password',
+  'could not read Username',
+  'could not read Password'
+];
+
 /** Parent class for all API requests */
 export class Git {
   constructor() {}

src/widgets/gitClone.ts

@@ -6,7 +6,7 @@ import { FileBrowser, IFileBrowserFactory } from '@jupyterlab/filebrowser';
 
 import { style } from 'typestyle';
 
-import { Git } from '../git';
+import { Git, AUTH_ERROR_MESSAGES } from '../git';
 
 import { GitCredentialsForm } from './CredentialsBox';
 
@@ -91,8 +91,9 @@ export class GitClone extends Widget {
         while (response.code !== 0) {
           if (
             response.code === 128 &&
-            (response.message.indexOf('could not read Username') >= 0 ||
-              response.message.indexOf('Invalid username or password') >= 0)
+            AUTH_ERROR_MESSAGES.map(
+              message => response.message.indexOf(message) > -1
+            ).indexOf(true) > -1
           ) {
             // request user credentials and try to clone again
             const dialog = new Dialog({

src/widgets/gitPushPull.ts

@@ -1,6 +1,6 @@
 import { Spinner } from '@jupyterlab/apputils';
 import { Widget } from '@phosphor/widgets';
-import { Git, IGitPushPullResult, IGitAuth } from '../git';
+import { Git, IGitPushPullResult, IGitAuth, AUTH_ERROR_MESSAGES } from '../git';
 
 export enum Operation {
   Pull = 'Pull',
@@ -75,8 +75,9 @@ export class GitPullPushDialog extends Widget {
     this.spinner.dispose();
     if (response.code !== 0) {
       if (
-        response.message.indexOf('could not read Username') >= 0 ||
-        response.message.indexOf('Invalid username or password') >= 0
+        AUTH_ERROR_MESSAGES.map(
+          message => response.message.indexOf(message) > -1
+        ).indexOf(true) > -1
       ) {
         this.handleError(response.message);
         this.parent!.parent!.close();