Stop file watcher on persistent errors #520
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Update test utils Fix mypy Fix incorrect update
krassowski
force-pushed
the
stop-if-only-errors
branch
from
6e78129 to
b50d076
Compare
krassowski
force-pushed
the
stop-if-only-errors
branch
from
12dd7a4 to
2c4b435
Compare
| ) | ||
|
|
||
| file_stop_poll_on_errors_after = Float( | ||
| 7 * 24 * 60 * 60, |
Collaborator
There was a problem hiding this comment.
Isn't 7 days too much?
Member
Author
There was a problem hiding this comment.
It is plenty. I was aiming at something which would allow users to still get a reload if they restore the file next day or so. Maybe we can use 24 hours.
Collaborator
There was a problem hiding this comment.
But if feels to me that this is not the right solution to the problem. Dow we agree with what I said here?
Member
Author
There was a problem hiding this comment.
Yes, that's why I opened jupyter-server/jupyter_server#1580. I am not sure if this should live in jupyter-server or jupyter-server-fileid (which was my initial thought too) but yes, long term that's the solution.
davidbrochart
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.