Merge pull request #316 from ryantam626/rt.go-to-cell

Add go to cell option in failure dialog

Author: ryantam626

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+**Jupyterlab extension**
+
+- Add "Go to cell" option in dialog when formatting fails;
+
 ## 2.2.1 2023-05-21
 
 **General**

README.md

@@ -47,9 +47,10 @@ To configure which/how formatters are invoked, see [configuration](https://jupyt
 I could really use your support in giving me a star on GitHub, recommending features, fixing bugs or maybe even providing monetary support!
 
 - [Recommending features via GitHub Issues](https://github.com/ryantam626/jupyterlab_code_formatter/issues)
-- [Sumitting your PR on GitHub](https://github.com/ryantam626/jupyterlab_code_formatter/pulls)
+- [Submitting your PR on GitHub](https://github.com/ryantam626/jupyterlab_code_formatter/pulls)
 - [Buy me a coffee](https://www.buymeacoffee.com/ryantam626)
-- [Donating Via Solana](https://solana.com/): 6K7aK5RpskJkhEkwZi1ZQr68LhaVdfnTfWjZEQV3VbbD
+
+Also shout-out to my employer [Huq Industires](https://huq.io/) for allowing me to work on this some of the time during work.
 
 ----
 

docs/changelog.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+**Jupyterlab extension**
+
+- Add "Go to cell" option in dialog when formatting fails;
+
 ## 2.2.1 2023-05-21
 
 **General**

src/formatter.ts

@@ -3,7 +3,7 @@ import { INotebookTracker, Notebook } from '@jupyterlab/notebook';
 import JupyterlabCodeFormatterClient from './client';
 import { IEditorTracker } from '@jupyterlab/fileeditor';
 import { Widget } from '@lumino/widgets';
-import { showErrorMessage } from '@jupyterlab/apputils';
+import { showErrorMessage, Dialog, showDialog } from '@jupyterlab/apputils';
 
 class JupyterlabCodeFormatter {
   working = false;
@@ -166,10 +166,20 @@ export class JupyterlabNotebookCodeFormatter extends JupyterlabCodeFormatter {
         if (cellValueHasNotChanged) {
           if (formattedText.error) {
             if (showErrors) {
-              await showErrorMessage(
-                'Jupyterlab Code Formatter Error',
-                formattedText.error
-              );
+              const result = await showDialog(
+                  {
+                      title: 'Jupyterlab Code Formatter Error',
+                      body: formattedText.error,
+                      buttons: [
+                        Dialog.createButton({label: 'Go to cell', actions: ['revealError']}),
+                        Dialog.okButton({ label: 'Dismiss' }),
+                      ]
+                  }
+              )
+              if (result.button.actions.indexOf('revealError') !== -1) {
+                this.notebookTracker.currentWidget!.content.scrollToCell(cell)
+                break
+              }
             }
           } else {
             cell.model.sharedModel.source = formattedText.code;