Skip to content

Commit 01c98ca

Browse files
authored
Start building Jupyter dedicated components (#4)
* Start Jupyter work * Use outline to highlight button focus, hover and active * Add margin on button to display properly the outline * Trial custom button * Use ts-loader for storybook * Add select * Fix outline highlight for outline appearance * Add fontawesome license * Add text-field * Embed more styling * Tune style for jp-option focus * Tune style for jp-select focus * Tune style for jp-text-field style * Add minimal attribute to button for toolbar * Add accent choice in toolbar * Add minimal style for select * Improve border contrast * Make minimal more dense * Upgrade yarn.lock * Restore react-component and lab example * Trim CSS variable value before converting it * Fix linter and add some snapshots * Update all snapshots * Fix MANIFEST.in * Fix snapshot * Add slow motion * Update snapshots
1 parent 316a616 commit 01c98ca

File tree

209 files changed

+3726
-8509
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

209 files changed

+3726
-8509
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
name: toolkit-ci
22

3-
on: pull_request
3+
on:
4+
push:
5+
branches: main
6+
pull_request:
7+
branches: main
48

59
jobs:
610
test:
@@ -34,56 +38,6 @@ jobs:
3438
run: yarn run test
3539
working-directory: packages/components
3640

37-
visual-test:
38-
runs-on: ubuntu-latest
39-
timeout-minutes: 10
40-
steps:
41-
- name: Checkout 🛎️
42-
uses: actions/checkout@v2
43-
44-
- name: Setup Node 💾
45-
uses: actions/setup-node@v2
46-
with:
47-
node-version: '14'
48-
49-
- name: Get yarn cache directory path
50-
id: yarn-cache-dir-path
51-
run: echo "::set-output name=dir::$(yarn cache dir)"
52-
- name: Setup yarn cache
53-
uses: actions/cache@v2
54-
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
55-
with:
56-
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
57-
key: yarn-${{ hashFiles('**/yarn.lock') }}
58-
restore-keys: |
59-
yarn-
60-
61-
- name: Install Dependencies 📥
62-
run: yarn install
63-
64-
- name: Install Playwright Browsers
65-
run: yarn run playwright install --with-deps
66-
working-directory: packages/components
67-
68-
- name: Run Visual Tests 🧪
69-
run: yarn run test:visual
70-
working-directory: packages/components
71-
72-
- name: Update Snapshots
73-
if: ${{ failure() }}
74-
run: |
75-
mv test-results test-assets
76-
yarn run test:visual -u
77-
working-directory: packages/components
78-
79-
- uses: actions/upload-artifact@v2
80-
if: ${{ failure() }}
81-
with:
82-
name: jupyter-ui-test
83-
path: |
84-
packages/components/test-assets/
85-
packages/components/src/**/*-snapshots/*
86-
8741
lint:
8842
runs-on: ubuntu-latest
8943
timeout-minutes: 10

.github/workflows/visual-test.yml

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
name: Toolkit Visual Test
2+
3+
on:
4+
push:
5+
branches: main
6+
pull_request:
7+
branches: main
8+
9+
jobs:
10+
visual-test:
11+
runs-on: ubuntu-latest
12+
timeout-minutes: 20
13+
steps:
14+
- name: Checkout 🛎️
15+
uses: actions/checkout@v2
16+
17+
- name: Setup Node 💾
18+
uses: actions/setup-node@v2
19+
with:
20+
node-version: '14'
21+
22+
- name: Get yarn cache directory path
23+
id: yarn-cache-dir-path
24+
run: echo "::set-output name=dir::$(yarn cache dir)"
25+
- name: Setup yarn cache
26+
uses: actions/cache@v2
27+
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
28+
with:
29+
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
30+
key: yarn-${{ hashFiles('**/yarn.lock') }}
31+
restore-keys: |
32+
yarn-
33+
34+
- name: Install Dependencies 📥
35+
run: yarn install
36+
37+
- name: Install Playwright Browsers
38+
run: yarn run playwright install --with-deps
39+
working-directory: packages/components
40+
41+
- name: Run Visual Tests 🧪
42+
run: yarn run test:visual
43+
working-directory: packages/components
44+
45+
- name: Update Snapshots
46+
if: ${{ failure() }}
47+
run: |
48+
mv test-results test-assets
49+
yarn run test:visual -u
50+
working-directory: packages/components
51+
52+
- uses: actions/upload-artifact@v2
53+
if: ${{ failure() }}
54+
with:
55+
name: jupyter-ui-test
56+
path: |
57+
packages/components/test-assets/
58+
packages/components/src/**/*-snapshots/*

MANIFEST.in

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ include packages/components/package.json
1717
include packages/components/jest.config.js
1818
include packages/components/playwright.config.ts
1919
include packages/components/rollup.config.js
20+
include packages/components/tsconfigbase.json
2021
include packages/components/tsconfig.json
22+
include packages/components/tsconfig.storybook.json
2123
graft packages/components/.storybook
2224
graft packages/components/docs
2325
graft packages/components/src

0 commit comments

Comments
 (0)