Skip to content

Commit 22774d3

Browse files
author
Justin Tyberg
committed
Do not require SSL cert, key files in make targets if SECRETS_VOLUME is set.
(c) Copyright IBM Corp. 2016
1 parent 7bc6a02 commit 22774d3

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

Makefile

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,28 @@ self-signed-cert:
1212
# make a self-signed cert
1313

1414
secrets/jupyterhub.crt:
15-
@if [ "${SECRETS_VOLUME}" = "" ]; then \
16-
echo "Need an SSL certificate in secrets/jupyterhub.crt"; \
17-
exit 1; \
18-
fi
15+
@echo "Need an SSL certificate in secrets/jupyterhub.crt"
16+
@exit 1
1917

2018
secrets/jupyterhub.key:
21-
@if [ "${SECRETS_VOLUME}" = "" ]; then \
22-
echo "Need an SSL key in secrets/jupyterhub.key"; \
23-
exit 1; \
24-
fi
19+
@echo "Need an SSL key in secrets/jupyterhub.key"
20+
@exit 1
2521

2622
userlist:
2723
@echo "Add usernames, one per line, to ./userlist, such as:"
2824
@echo " zoe admin"
2925
@echo " wash"
3026
@exit 1
3127

32-
check-files: secrets/jupyterhub.crt secrets/jupyterhub.key userlist
28+
# Do not require cert/key files if SECRETS_VOLUME defined
29+
secrets_volume = $(shell echo $(SECRETS_VOLUME))
30+
ifeq ($(secrets_volume),)
31+
cert_files=secrets/jupyterhub.crt secrets/jupyterhub.key
32+
else
33+
cert_files=
34+
endif
35+
36+
check-files: userlist $(cert_files)
3337

3438
pull:
3539
docker pull $(DOCKER_NOTEBOOK_IMAGE)

0 commit comments

Comments
 (0)