Skip to content

Commit 00068ee

Browse files
committed
Add more precise instructions for OAuth
1 parent dd964ad commit 00068ee

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,12 @@ by filling out a form on the GitHub site:
108108
In this form, you will specify the OAuth application's callback URL in
109109
this format: `https://<myhost.mydomain>/hub/oauth_callback`.
110110

111-
After submitting the GitHub form, your registered GitHub OAuth application is
112-
assigned a unique Client ID and Client Secret. The Client Secret should be
111+
After you submit the GitHub form, GitHub registers your OAuth application and
112+
assigns a unique Client ID and Client Secret. The Client Secret should be
113113
kept private.
114114

115-
You must pass the GitHub OAuth Client ID, Client Secret and OAuth callback url
116-
to JupyterHub at runtime. You can do this by either:
115+
At JupyterHub's runtime, you must pass the GitHub OAuth Client ID, Client
116+
Secret and OAuth callback url. You can do this by either:
117117

118118
- setting the `GITHUB_CLIENT_ID`, `GITHUB_CLIENT_SECRET`, and
119119
`OAUTH_CALLBACK_URL` environment variables when you run the

0 commit comments

Comments
 (0)