Skip to content

Commit fff7d4f

Browse files
authored
Merge pull request #467 from consideRatio/pr/require-jupyter-server-1.24
Require jupyter_server 1.24+, tornado 6.1+, traitlets 5.1+
2 parents 62a290f + ce53876 commit fff7d4f

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

.github/workflows/test.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
path: ./dist
6363

6464
test:
65-
name: ${{ matrix.os }} ${{ matrix.python-version }} ${{ matrix.pip-extras }}
65+
name: ${{ matrix.os }} ${{ matrix.python-version }} ${{ matrix.pip-extras }} ${{ (matrix.pip-install-constraints != '' && '(oldest deps)') || '' }}
6666
needs: [build]
6767
timeout-minutes: 30
6868
runs-on: ${{ matrix.os }}
@@ -87,16 +87,17 @@ jobs:
8787
python-version: "3.8"
8888
pip-extras: lab
8989

90+
include:
9091
# this test is manually updated to reflect the lower bounds of
9192
# versions from dependencies
9293
- os: ubuntu-22.04
9394
python-version: "3.8"
9495
pip-extras: classic
9596
pip-install-constraints: >-
96-
jupyter-server==1.0
97-
simpervisor==1.0
98-
tornado==5.1
99-
traitlets==4.2.1
97+
jupyter-server==1.24.0
98+
simpervisor==1.0.0
99+
tornado==6.1.0
100+
traitlets==5.1.0
100101
101102
steps:
102103
- uses: actions/checkout@v4
@@ -170,7 +171,7 @@ jobs:
170171
uses: actions/upload-artifact@v4
171172
with:
172173
name: |-
173-
tests-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.pip-extras }}-${{ github.run_attempt }}
174+
tests-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.pip-extras }}-${{ (matrix.pip-install-constraints != '' && 'oldest-') || '' }}${{ github.run_attempt }}
174175
path: |
175176
./build/pytest
176177
./build/coverage

pyproject.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ classifiers = [
4848
dependencies = [
4949
"aiohttp",
5050
"importlib_metadata >=4.8.3 ; python_version<\"3.10\"",
51-
"jupyter-server >=1.0",
52-
"simpervisor >=1.0",
53-
"tornado >=5.1",
54-
"traitlets >= 4.2.1",
51+
"jupyter-server >=1.24.0",
52+
"simpervisor >=1.0.0",
53+
"tornado >=6.1.0",
54+
"traitlets >= 5.1.0",
5555
]
5656

5757
[project.optional-dependencies]

0 commit comments

Comments
 (0)